← Back to issue list

More isolation of the helptext module and simplification of its usage (CRAFT-528)

View original Github issue

Metadata

Project
charmcraft
Number
#540
Type
pull request
State
merged
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #540 via commit 5794e30e, isolating helptext from app-specific details, simplifying get_usage_message, and relocating and decoupling related tests.

Resolution: closed resolved

Reason: PR #540 was merged into main as 5794e30e, with implementation commit c16417d4. It removed the application-name argument and eliminated test dependencies on COMMAND_GROUPS and VersionCommand.

Evaluated by: mr-cal-bot

No scores available.

Issue body

In detail: - Stop passing (again) the application name when calling `get_usage_message` - Moved two tests from "help suite" to "cmdbase suite" as they were more about the command's content than the help infrastructure - Fixed/improved tests so they don't depend anymore on `COMMAND_GROUPS` nor `VersionCommand`, which are app-specific

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #540 via commit 5794e30e, isolating helptext from app-specific details, simplifying get_usage_message, and relocating and decoupling related tests.
stealth/space-bunny-alpha — closed resolved Merged isolation of the helptext module and simpler get_usage_message usage for CRAFT-528, relocating command-content tests and removing app-specific dependencies.
qwen/qwen3.6-35b-a3b — — Merged after approval and passing CI. Isolated the helptext module and simplified usage by removing the application name parameter from get_usage_message. Refactored tests to eliminate dependencies on app-specific components like COMMAND_GROUPS and VersionCommand.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes isolating the helptext module and simplifying its usage. Removed the application name parameter from get_usage_message, relocated tests to the cmdbase suite, and eliminated app-specific dependencies like COMMAND_GROUPS and VersionCommand.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.