← Back to issue list

Moved the config loaded (with proper dir specification) outside of the Dispatcher (CRAFT-561).

View original Github issue

Metadata

Project
charmcraft
Number
#564
Type
pull request
State
merged
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

Merged into main via PR #564 (commit d1898163, merge 2b993f6f), moving config loading and explicit directory handling out of Dispatcher.

Resolution: closed resolved

Reason: PR #564 was merged into main. Commit d1898163 moved config loading with proper project-directory handling out of Dispatcher and updated the affected tests.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The PR is big, but most of it are mechanical changes in the tests. For example in `test_help.py`, because the moment where the exception is raised to provide help changed location (previously everything happened on Dispatch instantiaton, and now it may happen when `pre_parse_args` or `load_command`. Also, `--project-dir` is not included by default anymore in the tests.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged into main via PR #564 (commit d1898163, merge 2b993f6f), moving config loading and explicit directory handling out of Dispatcher.
stealth/space-bunny-alpha — closed resolved Merged PR #564 (CRAFT-561), moving config loading with explicit directory handling out of Dispatcher and updating affected tests.
qwen/qwen3.6-35b-a3b — — Merged refactoring that relocated config loading with explicit directory specification outside the Dispatcher. Exception handling timing changed and test flag adjustments required mechanical updates. Approved and merged.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Config loading moved outside the Dispatcher with explicit directory specification, resolving CRAFT-561. Tests updated mechanically to reflect shifted exception handling and removal of the default --project-dir flag.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.