← Back to issue list

Put complete-structure test zip under tmp_path

View original Github issue

Metadata

Project
charmcraft
Number
#60
Type
pull request
State
merged
Author
chipaca
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #60 (commit e1944189) moved the complete-structure test into tmp_path, ensuring its generated ZIP is cleaned up instead of left behind.

Resolution: closed resolved

Reason: PR #60 was merged as commit e1944189. It updated test_build_basic_complete_structure to use tmp_path, preventing test-generated ZIP artifacts from persisting.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Avoid leaving behind a zip after tests. Run test_build_basic_complete_structure in tmp_path as done in test_build_package_tree_structure and test_build_package_name. The latter two call builder.handle_package(), which writes the zip. The former calls builder.run(), which gets there indirectly.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #60 (commit e1944189) moved the complete-structure test into tmp_path, ensuring its generated ZIP is cleaned up instead of left behind.
stealth/space-bunny-alpha — closed resolved Merged test cleanup: test_build_basic_complete_structure now runs under tmp_path, preventing generated zip files from being left behind.
stealth/space-bunny-alpha — closed resolved Merged charmcraft#60 to run the complete-structure build test under tmp_path, preventing leftover zip artifacts; approved by two reviewers.
qwen/qwen3.6-35b-a3b — — Merged a change to run the complete-structure test in a temporary directory, preventing leftover zip files after execution. Approved by two reviewers and passed CI.
qwen3.6-35b-a3b-mtp-q6 — — Merged a change to run the complete-structure test within a tmp_path fixture, preventing leftover zip files after execution. This applies the same cleanup pattern used in similar package tests.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.