← Back to issue list

Massive renaming of CommandError to CraftError (CRAFT-709).

View original Github issue

Metadata

Project
charmcraft
Number
#624
Type
pull request
State
merged
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

Merged renaming CommandError to CraftError across 36 files. Imports updated to craft_cli and the old definition removed. A CharmcraftError subclass suggestion was declined, as CraftError already provides sufficient functionality.

Suggested action: —

No scores available.

Issue body

The only "real changes" are the import changes from cmdbase to craft_cli, and of course the removal of the no longer used CommandError definition.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged renaming CommandError to CraftError across 36 files. Imports updated to craft_cli and the old definition removed. A CharmcraftError subclass suggestion was declined, as CraftError already provides sufficient functionality.
qwen3.6-35b-a3b-mtp-q6 — — Merged renaming CommandError to CraftError, updating imports to craft_cli and removing the obsolete definition. A proposal for an intermediate CharmcraftError was declined, as CraftError already provides sufficient functionality for direct use.
qwen3.6-35b-a3b-mtp-q6 — — Merged renaming CommandError to CraftError, updating imports to craft_cli and removing the old definition. A proposal for an intermediate CharmcraftError class was declined, as CraftError already provides sufficient functionality.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#264 feat: add CraftCommandError craft-cli merged Merged implementation of CraftCommandError class with a stderr attribute for command output. Approved by two reviewers, passed CI checks, and resolves issue #260 across seven files.
72%
#505 Use specific ArgumentParsingError for argument parsing errors (CRAFT-473). charmcraft merged Merged. Introduces a dedicated ArgumentParsingError to replace the overloaded CommandError, simplifying help handling and preparing for craft-cli integration. Changes span five files.
71%