← Back to issue list

Use all functionality from craft-cli (CRAFT-710).

View original Github issue

Metadata

Project
charmcraft
Number
#635
Type
pull request
State
merged
Author
facundobatista
Labels
Created
Updated
Closed

Current evaluation

Merged after approval. Integrated all craft-cli functionality, netting a reduction of 1724 lines across 11 files. Resolves CRAFT-710.

Suggested action:

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after approval. Integrated all craft-cli functionality, netting a reduction of 1724 lines across 11 files. Resolves CRAFT-710.
qwen3.6-35b-a3b-mtp-q6 Merged to integrate all remaining craft-cli functionality, resolving CRAFT-710. The maintainer-approved changes were successfully added to the codebase without additional review comments.
qwen3.6-35b-a3b-mtp-q6 Merged implementation of full craft-cli functionality per CRAFT-710. The maintainer submitted the changes, which were accepted and merged directly without additional discussion or modifications.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#754 Use the Craft CLI lib fixtures (CRAFT-995). charmcraft merged Merged to implement CRAFT-995, switching to the Craft CLI lib fixtures. The update modifies three files with a net reduction of 148 lines. Approved by one reviewer and merged without comments.
76%
#577 Craft cli integration charmcraft merged Merged the Craft CLI integration authored by maintainer facundobatista. Approved by one reviewer, the change modifies 45 files with 922 additions and 1358 deletions, successfully implementing command-line interface support.
76%
#648 Updated dependencies to include craft-cli 0.2 charmcraft merged Merged after approval. Updated dependencies to include craft-cli 0.2 across six files, resulting in 45 additions and 53 deletions.
75%
#26 cli: parse command line using craft-cli rockcraft merged Merged after approval and passing CI. Replaced the temporary CLI parser with craft-cli's subsystem and defined the pack command. Modified 12 files, adding 144 lines and removing 197.
74%
#5205 refactor: use craft-platforms utilities snapcraft merged Merged following approval by two reviewers. Refactored the codebase to use craft-platforms utilities, resolving CRAFT-3278 and closing #4993. Net reduction of 307 lines across 20 files.
74%
#298 dependencies: update craft-cli to 2.0.0 rockcraft merged Merged update to craft-cli version 2.0.0. The change modified three files with a three-line diff. Approved by two reviewers and integrated.
74%
#29 tests: use the Craft CLI lib fixtures rockcraft merged Merged updates to replace test fixtures with the Craft CLI library version. Approved by one reviewer, modifying five files (+11/-54 lines). Resolves CRAFT-996.
73%
#3736 requirements: update dependencies snapcraft merged Merged update bumping craft-cli to version 0.6.0. Approved by one reviewer with no unresolved comments. Changes modified two files (+4/-4 lines) with passing CI checks.
72%
#398 Remove now unused functionalities (CRAFT-241). charmcraft merged Merged following approval by two reviewers. Removed unused functionalities referenced as CRAFT-241, altering two files with a net deletion of 229 lines. No unresolved review comments or CI checks were required.
72%
#3626 cli: integrate craft-cli and add version command (CRAFT-730) snapcraft merged Merged after integrating craft-cli and adding a version command, falling back to the legacy implementation for other functionality. Passed CI, approved, and merged. Help output remains handled by the legacy system until fully updated.
71%