← Back to issue list

A small refactor creating a "store api" layer between commands and the client

View original Github issue

Metadata

Project
charmcraft
Number
#67
Type
pull request
State
merged
Author
facundobatista
Labels
Created
Updated
Closed

Current evaluation

Merged a refactor creating a store API layer to isolate store interactions from commands and return structured data. Added tabulate formatting for the Whoami command. Approved by two reviewers, modifying seven files (+184/-43).

Suggested action:

No scores available.

Issue body

Note that this new layer returns hard-defined structures to the commands (not leaking whatever the store returns). IOW, all dealing-with-store issues are isolated from the commands. Also I started using `tabulate` for the Whoami command; it may look as overkill for just that, but will use tabulate for other commands in subsequent branches, so let's start here... This is a work preparing for bringing more commands later (#62).

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a refactor creating a store API layer to isolate store interactions from commands and return structured data. Added tabulate formatting for the Whoami command. Approved by two reviewers, modifying seven files (+184/-43).
qwen3.6-35b-a3b-mtp-q6 Merged a refactor introducing a store API layer that isolates store interactions from commands via fixed return structures. Added tabulate formatting to the Whoami command to establish a pattern for future command implementations.
qwen3.6-35b-a3b-mtp-q6 Merged a refactor introducing a store api layer to isolate store interactions from commands and return standardized structures. Added tabulate to the Whoami command as groundwork for future command implementations.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#94 Store commands autocomplete charmcraft merged Merged the store commands autocomplete implementation. Approved by two reviewers and dependent on PR #93. The commit modifies one file with a +21/-2 line diff, incorporating review feedback from @chipaca.
72%
#1302 style: clean up store command imports charmcraft merged Merged after approval by two reviewers. The PR cleans up store command imports, modifying one file with 32 additions and 44 deletions. An unrelated codespell lint failure in test_package.py was noted and resolved separately.
70%