Show lifecycle step progress (and related fix for always getting the instance logs).
Metadata
Current evaluation
Merged changes adding lifecycle step progress display and fixing instance log capture on success and error. Uses Emitter.pause() to ensure logs are always captured. Consolidates output messages and improves zip file logging. Approved and passed CI checks.
Suggested action: —
No scores available.
Issue body
The main change in this branch is showing progress on each step, so the user may be aware of what goes on.
As that happens in the instance, I needed to use the new Emitter's `.pause()` functionality. That led to a related fix that had to go into this branch, which is always getting the instance log, on error *and* on execution success (this is because as the emitter is being paused we lose getting the instance output from the terminal... IOW, would never capture the instance logs, not even in verbose, unless we have an error of course).
Also, two output related improvements:
- now the output from the inner charmcraft is directly shown in the screen (the outer one emitter is paused) so for each base we pack it puts the "Charms packed: (...)" message; I added code for this to not happen, so the only "final message" that is shown is from the outer charmcraft, with all the packed bases
- as I was testing different runs/output combinations, I found that the message of the created zip file is better to be shown as intermediate (so it appears with the timestamp in verbose mode)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged changes adding lifecycle step progress display and fixing instance log capture on success and error. Uses Emitter.pause() to ensure logs are always captured. Consolidates output messages and improves zip file logging. Approved and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged by facundobatista. Added lifecycle step progress via Emitter pause, fixed instance log capture to always record on success and error, and improved output formatting for inner charmcraft and zip file messages. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Implements lifecycle step progress tracking and fixes instance log capture on success and error via Emitter.pause(). Updates output to show inner charmcraft progress directly and displays zip file creation timestamps in verbose mode. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4461 fix: improve lifecycle messages | snapcraft | merged | Merged after approval and passing CI. The change improves lifecycle messages by refactoring progress emission from open_stream to explicit progress calls, maintaining code coverage. | |
| #52 lifecycle: emit progress for packing | craft-application | merged | Merged into main. Adds progress emission during packing to prevent a long ticker on the Lifecycle finished message. Approved by two reviewers, passed CI, and modified two files with two added lines. |