← Back to issue list

Show lifecycle step progress (and related fix for always getting the instance logs).

View original Github issue

Metadata

Project
charmcraft
Number
#726
Type
pull request
State
merged
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

Merged in canonical/charmcraft#726 (6a05a07a), adding lifecycle-step progress, retrieving instance logs on success and failure, and refining terminal output.

Resolution: closed resolved

Reason: PR #726 was merged via commit 6a05a07a, with implementation in cc7d9ee0. It added lifecycle progress and ensured instance logs are captured on both successful and failed runs.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The main change in this branch is showing progress on each step, so the user may be aware of what goes on. As that happens in the instance, I needed to use the new Emitter's `.pause()` functionality. That led to a related fix that had to go into this branch, which is always getting the instance log, on error *and* on execution success (this is because as the emitter is being paused we lose getting the instance output from the terminal... IOW, would never capture the instance logs, not even in verbose, unless we have an error of course). Also, two output related improvements: - now the output from the inner charmcraft is directly shown in the screen (the outer one emitter is paused) so for each base we pack it puts the "Charms packed: (...)" message; I added code for this to not happen, so the only "final message" that is shown is from the outer charmcraft, with all the packed bases - as I was testing different runs/output combinations, I found that the message of the created zip file is better to be shown as intermediate (so it appears with the timestamp in verbose mode)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in canonical/charmcraft#726 (6a05a07a), adding lifecycle-step progress, retrieving instance logs on success and failure, and refining terminal output.
stealth/space-bunny-alpha — closed resolved Merged in canonical/charmcraft#726 (6a05a07a), adding lifecycle-step progress and ensuring instance logs are captured on both errors and successful runs.
stealth/space-bunny-alpha — closed resolved Merged in canonical/charmcraft#726 (6a05a07a), adding lifecycle-step progress, preserving successful-run instance logs, and improving nested output.
stealth/space-bunny-alpha — closed resolved Merged in canonical/charmcraft#726 (6a05a07a), adding lifecycle-step progress and ensuring instance logs are captured on both errors and successful runs.
qwen/qwen3.6-35b-a3b — — Merged changes adding lifecycle step progress display and fixing instance log capture on success and error. Uses Emitter.pause() to ensure logs are always captured. Consolidates output messages and improves zip file logging. Approved and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged by facundobatista. Added lifecycle step progress via Emitter pause, fixed instance log capture to always record on success and error, and improved output formatting for inner charmcraft and zip file messages.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#717 Expose lifecycle step updates when packing charmcraft closed Packing lifecycle step progress was implemented in canonical/charmcraft#726 ("Show lifecycle step progress"), merged as 6a05a07a (commit cc7d9ee0), plus a fix to always fetch instance logs; closed the issue.
80%