← Back to issue list

Pause the emitter while launching the user-requested shell (CRAFT-871).

View original Github issue

Metadata

Project
charmcraft
Number
#753
Type
pull request
State
merged
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

Merged #753 via 47832a45, pausing Charmcraft’s emitter during user-requested shell launches and fixing how flake8 issues are reported.

Resolution: closed resolved

Reason: PR #753 was approved and merged as commit 47832a45, with implementation commit 35409faf. It pauses output emission during requested shell launches and corrects flake8 issue reporting.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Took the opportunity to fix how flake8 issues were reported.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #753 via 47832a45, pausing Charmcraft’s emitter during user-requested shell launches and fixing how flake8 issues are reported.
stealth/space-bunny-alpha — closed resolved Merged in canonical/charmcraft#753 (commit 47832a45) on branch pause-emitter-for-shell: pauses the emitter around user-requested shell launches and fixes flake8 issue reporting.
stealth/space-bunny-alpha — closed resolved Merged in canonical/charmcraft#753 (commit 47832a45), pausing the emitter during user-requested shell launches and correcting flake8 issue reporting.
stealth/space-bunny-alpha — closed resolved Merged canonical/charmcraft#753, pausing the emitter during user-requested shell launches for CRAFT-871 and correcting flake8 issue reporting (commit 35409faf).
stealth/space-bunny-alpha — closed resolved Merged canonical/charmcraft#753 (47832a45), pausing the emitter during user-requested shell launches and improving flake8 issue reporting.
qwen/qwen3.6-35b-a3b — — Merged after approval. Pauses the emitter during user-requested shell launches to resolve CRAFT-871. Also corrected flake8 issue reporting.
qwen3.6-35b-a3b-mtp-q6 — — Merged to pause the emitter during user-requested shell launches, resolving CRAFT-871. Also corrected flake8 issue reporting.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#740 Pause the Emitter when asking the user for input (CRAFT-952). charmcraft merged Merged #740 (e70ed86f; implementation 9acf2caa), pausing Charmcraft's Emitter during user-input prompts; the author confirmed it was tested on Windows.
76%
#67 Allow emitter to be paused craft-cli closed Emitter pausing was implemented and merged in canonical/craft-cli#69 via b8cbbc6 (merge d8171ce), with pause-related fixes in #71.
72%