Always validate the entrypoint, no matter its source.
Metadata
Current evaluation
Merged PR #767 (4b64ec0f) unified entrypoint validation across config, deprecated CLI options, and defaults, including absolute config paths and fixing #761.
Resolution: closed resolved
Reason: PR #767 was approved and merged as commit 4b64ec0f. It now validates the entrypoint regardless of its source, resolving the missing default and absolute-path validation reported in #761.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The code is somewhat entangled, because we're currently supporting different sources for entrypoint: configuration, command line option (deprecated), and the default when the developer didn't specify anything.
Besides the several explicit cases that I started to validate, I added one validation for the case of writing the absolute path in the config, which was missing, surely because when the parts lifecycle and plugin were introduced the entrypoint path started to be always relative, when before it was always absolute.
There's a remaining duplicated validation that will disappear when deprecations are enforced. This whole code will be quite more simple after that.
Fixes #761 .
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #767 (4b64ec0f) unified entrypoint validation across config, deprecated CLI options, and defaults, including absolute config paths and fixing #761. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged validation for every entrypoint source, including missing validation for absolute paths in configuration. It fixes #761 and simplifies duplicate checks once deprecated entrypoint handling is removed. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval and CI. Adds comprehensive entrypoint validation across all sources, including a previously missing check for absolute paths in configuration. Resolves #761 and simplifies code ahead of deprecation enforcement. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes that enforce entrypoint validation regardless of source, adding a missing check for absolute paths in configuration files. Resolves #761. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/charmcraft#761
(confidence 100%)
The reported missing entrypoint validation was explicitly fixed by PR #767.
Related issues
No related issues found above the similarity threshold.