← Back to issue list

Consolidate the charm plugin configuration in its properties (CRAFT-1156).

View original Github issue

Metadata

Project
charmcraft
Number
#808
Type
pull request
State
merged
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #808 consolidated charm plugin settings into part properties, simplifying configuration and validation for CRAFT-1156.

Resolution: closed resolved

Reason: PR #808 was merged into main as commit 7563ce5e, delivering the CRAFT-1156 configuration consolidation and receiving approval from two reviewers.

Evaluated by: mr-cal-bot

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #808 consolidated charm plugin settings into part properties, simplifying configuration and validation for CRAFT-1156.
stealth/space-bunny-alpha — closed resolved Merged canonical/charmcraft#808 in 7563ce5e, consolidating charm plugin configuration into part properties to simplify implementation and validation for CRAFT-1156.
stealth/space-bunny-alpha — closed resolved Merged PR #808, consolidating charm plugin configuration into part properties and simplifying validation for CRAFT-1156; merge commit 7563ce5e.
stealth/space-bunny-alpha — closed resolved Merged canonical/charmcraft#808, consolidating charm plugin configuration into part properties to simplify implementation and validation for CRAFT-1156.
qwen/qwen3.6-35b-a3b — — Merged consolidation of charm plugin configuration into its properties. Approved by two reviewers, the change simplifies implementation and clarifies validation choices. Updated six files with a net reduction of 318 lines.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes consolidating charm plugin configuration into its properties (CRAFT-1156). Reviewer confirmed alignment with prior discussions, noted simplified implementation, and requested clarification on validation choices.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#450 parts: add charm plugin (CRAFT-89) charmcraft closed Closed unmerged; CRAFT-89 landed via superseding PR #458, merged as 9dc20872 with implementation commit 437dab55.
71%