Improved init "simple" templates using the correct source
Metadata
Current evaluation
Merged #855 (3e0950c8), aligning simple init output with canonical templates, correcting substitutions, style and URLs, and removing init TODO messages.
Resolution: closed resolved
Reason: PR #855 was merged as commit 3e0950c8. It updated generated simple charm templates to match canonical sources and removed TODO messages from init output.
Evaluated by: mr-cal-bot
No scores available.
Issue body
There are some slight differences between [the templates in the correct source](https://github.com/canonical/template-operator/tree/charmcraft-templates/default) and files after producing a new charm running `init` ([full real diff](https://pastebin.ubuntu.com/p/rjdwsn8TCV/)):
- `charmcraft.yaml`: better indentation
- `.gitignore`: added a newline at the end of last line
- `tox.ini`: used `pdb` in `PYTHONBREAKPOINT`
- several replacements of `{{ year }} {{ author }}` by actual values
- several replacements of `{{ name }}` by the charm name
- several replacements of `{{ class_name }}` by the charm class name
- removed the final `.` in a couple of URLs (the final dot would make the URL invalid)
- fixed some style changes (complained by pep257, black, etc):
- removed spaces in a blank line
- improved a couple of docstrings to use the imperative form
- collapsed some code to be in the same line
- kept from previous code a helping message that informs how to see the charm generated logs using Juju
Also removed the TODO messages from the response of the command. This output may be improved next week.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #855 (3e0950c8), aligning simple init output with canonical templates, correcting substitutions, style and URLs, and removing init TODO messages. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #855 (commit 3e0950c8), updating init “simple” templates to match canonical source, with correct substitutions, indentation, URLs, style, and no init TODO output. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval. Updates init simple templates to match the canonical source, fixing YAML indentation, variable substitution, URL syntax, and style compliance. Removes TODO messages from CLI output. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged updates to init simple templates, aligning with the canonical source. Fixes indentation, newlines, variable substitution, URLs, style issues, and removes TODO messages from output. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #107 feat: add simple init template | debcraft | merged | Merged PR #107 added a simple init template (17 lines in one file); the merged commit is 4bf617f. | |
| #225 Better init template outputs: correct license and not real actions/config contents | charmcraft | merged | Merged #225 in commit 7d2719ac, correcting the init template license and replacing real actions/config contents with placeholders. |