← Back to issue list

Added a machine profile to init command (CRAFT-1046).

View original Github issue

Metadata

Project
charmcraft
Number
#868
Type
pull request
State
merged
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #868 added a machine profile to charmcraft init, resolving #568 and #593; merge commit: a6c21119.

Resolution: closed resolved

Reason: Merged in commit a6c21119 after approval by two reviewers. The merged change added machine-profile initialization and explicitly states that it fixes #568 and #593.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Fixes #568 and #593.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #868 added a machine profile to charmcraft init, resolving #568 and #593; merge commit: a6c21119.
stealth/space-bunny-alpha — closed resolved Merged PR #868, adding a machine profile to the init command. Approved by two reviewers; merge commit a6c21119 fixes issues #568 and #593.
qwen/qwen3.6-35b-a3b — — Merged. Added a machine profile to the init command, resolving issues #568 and #593. Approved by two reviewers with zero unresolved comments. Changes span 15 files with 156 additions and 16 deletions.
qwen3.6-35b-a3b-mtp-q6 — — Merged the addition of a machine profile to the init command, resolving issues #568 and #593. The change was integrated into the codebase by maintainer facundobatista.

Update history

No update history recorded yet.

Related work

  • Related To: charmcraft#568 (confidence 100%)

    PR #868 added the requested machine-charm initialization profile.

  • Related To: charmcraft#593 (confidence 100%)

    PR #868 explicitly identifies this issue as fixed by the machine-profile change.

Related issues

Issue Project State Summary Similarity
#854 Created the profile option for the init command (CRAFT-1317). charmcraft merged Merged PR #854 as commit 21b83fb0, adding an optional charmcraft init profile that defaults to simple and updating its scaffold template for CRAFT-1317.
78%
#2401 feat(test): add testing profiles for init command charmcraft merged Merged PR #2401 as commit a7334d49, adding test-machine and test-kubernetes init profiles for charmcraft test; the feature shipped in Charmcraft 4.0.
75%
#1139 `charmcraft init --profile machine` doesn't produce `config.yaml` charmcraft closed Fixed in canonical/charmcraft#1149 via commit ca4df024: machine init now uses charmcraft.yaml and no longer tells users to edit metadata.yaml or config.yaml.
75%
#1259 Init output issue charmcraft closed Fixed by merged PR #1149 (commit ca4df024): machine-profile init no longer advertises nonexistent config.yaml and metadata.yaml after adopting charmcraft.yaml.
75%
#2167 charmcraft init --profile machine does not produce a valid charmcraft.yaml charmcraft closed Fixed by #2200 (commit c4d43add), which migrated the machine init template from legacy bases syntax to platforms.
74%
#859 Added a kubernetes profile to init command (CRAFT-1318). charmcraft merged Merged in canonical/charmcraft#859 (451c399a), adding the Kubernetes init profile and fixing the simple template for CRAFT-1318.
74%
#328 charmcraft init produces error charm for machine charms charmcraft closed Machine charms gained a dedicated charmcraft init profile, resolving Kubernetes-only initialization; the change was merged in PR #868 (commit 2ed9033c).
74%
#1158 command: add profiles descriptions and update URL (#1156) charmcraft merged Merged charmcraft#1156 via commits 15fba942 and 5b50d9e6, adding init profile descriptions and correcting the associated URL.
73%