← Back to issue list

Support both image id and digest when uploading oci-image resources (CRAFT-1324).

View original Github issue

Metadata

Project
charmcraft
Number
#871
Type
pull request
State
merged
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

Merged in canonical/charmcraft#871 via commit cefabea2, adding OCI image ID and digest support, faster local-ID handling, clearer missing-image errors, and resolution of #853.

Resolution: closed resolved

Reason: PR #871 was approved and merged as commit cefabea2. It enables upload-resource to handle both local image IDs and remote or local digests, closing #853.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Also be very explicit on which one is used when. It results on being quicker if the id is used (no check on remote registry) and better messages to the user. Which were improved also: not all needed to be permanent, and actually ended in error if the image to upload is not found and nothing can be done. Fixes #853.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in canonical/charmcraft#871 via commit cefabea2, adding OCI image ID and digest support, faster local-ID handling, clearer missing-image errors, and resolution of #853.
stealth/space-bunny-alpha — closed resolved Merged charmcraft#871 via cefabea2, adding image ID and digest support for OCI uploads, faster ID-based handling, and clearer missing-image errors; fixes #853.
qwen/qwen3.6-35b-a3b — — Merged implementation supporting both image ID and digest for OCI image uploads. ID usage bypasses remote registry checks for faster processing, while improved messaging handles missing images gracefully. Resolves #853.
qwen3.6-35b-a3b-mtp-q6 — — Merged to enable OCI image resource uploads using either image ID or digest. The ID bypasses remote registry checks for faster uploads. Improved error messaging and resolved issue #853.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/charmcraft#853 (confidence 100%)

    The merged PR explicitly fixes the OCI upload-resource ID-or-digest issue.

Related issues

Issue Project State Summary Similarity
#444 unable to upload oci-image resource from dockerhub using image digest charmcraft closed Closed by maintainer facundobatista as superseded: charmcraft 1.1.1 (in candidate at the time) reworked OCI uploads to push images from the local machine and always reference them by digest, so the reported remote-digest limitation no longer applied.
76%
#853 The upload-resource command should accept images id or digests charmcraft closed Merged PR #871 resolved support for OCI image IDs and digests in upload-resource, improving local ID handling and missing-image errors.
75%
#1953 Charmcraft 3 should still accept image digests for `upload-resource` charmcraft open Maintainer-filed Charmcraft 3 bug remains open: upload-resource still rejects bare OCI digests because Docker lookup returns only image IDs; no resolving change is present.
73%
#5 oci: add oci image manipulation support (CRAFT-579) rockcraft merged Merged in canonical/rockcraft#5 (42058699), adding OCI base-image retrieval, extraction, primed-content repacking, and OCI archive creation for CRAFT-579.
72%
#296 Support uploading oci-image resources. charmcraft merged Merged PR #296 added OCI-image resource uploads via implementation commit 4b9cdeb4 and merge commit 8f00348f.
72%