← Back to issue list

(internal) Moved user confirmation on provider installation (CRAFT-1401)

View original Github issue

Metadata

Project
charmcraft
Number
#894
Type
pull request
State
merged
Author
facundobatista
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #894, moving user confirmation for provider installation; implementation d88f8cc9 landed via merge commit c129d921.

Resolution: closed resolved

Reason: PR #894 was approved and merged into the project. Commit d88f8cc9 implemented the confirmation-flow change and c129d921 recorded the merge.

Evaluated by: mr-cal-bot

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #894, moving user confirmation for provider installation; implementation d88f8cc9 landed via merge commit c129d921.
stealth/space-bunny-alpha — closed resolved Moved provider-installation confirmation for CRAFT-1401; merged via PR #894 in d88f8cc9 with merge commit c129d921.
stealth/space-bunny-alpha — closed resolved Merged PR #894, moving the user-confirmation step for provider installation; implemented in d88f8cc9 and merged by c129d921.
qwen/qwen3.6-35b-a3b — — Merged changes moving user confirmation during provider installation, resolving CRAFT-1401. Approved by one reviewer, the update modified nine files with a net reduction of 27 lines.
qwen3.6-35b-a3b-mtp-q6 — — Merged internal pull request moving user confirmation logic during provider installation. Resolves CRAFT-1401. Approved and merged by maintainer facundobatista without additional comments.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3938 providers: move `confirm_with_user()` call to providers.py (#91) snapcraft merged Merged #3938 moved Snapcraft's confirm_with_user() prompt out of the craft-providers interface and into providers.py; landed as commit 792d45f2f.
73%
#91 providers: move `confirm_with_user()` call to providers.py rockcraft merged Merged PR #91 as b189a224, moving Rockcraft-specific confirm_with_user() into providers.py and renaming is_provider_available() to is_provider_installed().
71%