← Back to issue list

(internal) Moved user confirmation on provider installation (CRAFT-1401)

View original Github issue

Metadata

Project
charmcraft
Number
#894
Type
pull request
State
merged
Author
facundobatista
Labels
Created
Updated
Closed

Current evaluation

Merged changes moving user confirmation during provider installation, resolving CRAFT-1401. Approved by one reviewer, the update modified nine files with a net reduction of 27 lines.

Suggested action:

No scores available.

Issue body

No description provided.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged changes moving user confirmation during provider installation, resolving CRAFT-1401. Approved by one reviewer, the update modified nine files with a net reduction of 27 lines.
qwen3.6-35b-a3b-mtp-q6 Merged internal pull request moving user confirmation logic during provider installation. Resolves CRAFT-1401. Approved and merged by maintainer facundobatista without additional comments.
qwen3.6-35b-a3b-mtp-q6 Merged maintainer facundobatista's internal pull request that repositions user confirmation prompts during provider installation, resolving CRAFT-1401. Accepted without review comments.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#91 providers: move `confirm_with_user()` call to providers.py rockcraft merged Merged after approval and passing CI. Moved the rockcraft-specific confirm_with_user logic out of the craft-providers interface into providers.py. Renamed is_provider_available to is_provider_installed across ten files.
76%
#3938 providers: move `confirm_with_user()` call to providers.py (#91) snapcraft merged Merged changes moving the snapcraft-specific confirm_with_user() call out of the craft-providers interface into providers.py. The update was approved, passed CI, and aligns with parallel rockcraft modifications.
71%