← Back to issue list

templates: remove duplicate "await"

View original Github issue

Metadata

Project
charmcraft
Number
#911
Type
pull request
State
merged
Author
cjwatson
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #911 removed duplicate awaits from three integration-test templates in commit 3ea45cd3, fixing #910.

Resolution: closed resolved

Reason: PR #911 was merged as commit 3ea45cd3 and removed the erroneous second await after build_charm in three template files. The PR explicitly states that it fixes charmcraft#910.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The integration tests already do `charm = await ops_test.build_charm(".")` earlier, so it doesn't make sense to await again on the result of that. Fixes #910.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #911 removed duplicate awaits from three integration-test templates in commit 3ea45cd3, fixing #910.
stealth/space-bunny-alpha — closed resolved Merged #911 in commit 3ea45cd3, removing duplicate await calls from three integration-test templates and fixing #910.
stealth/space-bunny-alpha — closed resolved Merged PR #911 in commit 3ea45cd3, removing duplicate await calls from three integration-test templates and fixing #910.
stealth/space-bunny-alpha — closed resolved Merged PR #911 removed three duplicate await calls from integration-test templates, fixing charmcraft#910.
stealth/space-bunny-alpha — closed resolved Merged PR #911 in commit 3ea45cd3, removing three duplicate await calls from integration test templates and fixing #910.
qwen/qwen3.6-35b-a3b — — Merged to remove duplicate await in integration tests, resolving #910. Approved by one reviewer, the change modifies three files with minimal line adjustments.
qwen3.6-35b-a3b-mtp-q6 — — Merged removal of a redundant await in integration tests, resolving issue #910. The duplicate await was unnecessary since the charm was already awaited during the build step.

Update history

No update history recorded yet.

Related work

  • Related To: charmcraft#910 (confidence 100%)

    The linked duplicate-await issue is explicitly identified as fixed by merged PR #911.

Related issues

Issue Project State Summary Similarity
#910 Duplicate await in integration test templates charmcraft closed Fixed charmcraft init integration templates in commit 3ea45cd3 by removing the duplicate await before deployment, preventing a PosixPath TypeError.
75%