← Back to issue list

refactor: isolate the charm lib internals extractor

View original Github issue

Metadata

Project
charmcraft
Number
#998
Type
pull request
State
merged
Author
facundobatista
Labels
Created
Updated
Closed

Current evaluation

Merged a refactoring that isolates the charm lib internals extractor to prepare for AST-based parsing. Code and tests were reorganized without functional changes, with some tests collapsed via parametrize. Approved and passed CI.

Suggested action:

No scores available.

Issue body

This is a preparation PR before changing the charmlib parsing to use AST. It does not change any code, just move it around, including tests (some of which are collapsed using parametrize).

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a refactoring that isolates the charm lib internals extractor to prepare for AST-based parsing. Code and tests were reorganized without functional changes, with some tests collapsed via parametrize. Approved and passed CI.
qwen3.6-35b-a3b-mtp-q6 Merged a refactoring change that isolates the charm lib internals extractor. Code and tests were reorganized without functional changes to prepare for upcoming AST-based charmlib parsing.
qwen3.6-35b-a3b-mtp-q6 Merged a refactoring change that isolates the charm lib internals extractor by reorganizing code and tests without functional changes, preparing the codebase for switching charmlib parsing to AST.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#831 Fixed/simplified some tests to isolate them of underlying apt. charmcraft merged Merged test refactoring that isolates three tests from external apt dependencies. Replaced a charm plugin with a null plugin, removed a flawed integration test, and improved project setup for a linter test. CI passed.
72%