← Back to issue list

chore(deps): update dependency eslint to v10.14.0

View original Github issue

Metadata

Project
craft-actions
Number
#145
Type
pull request
State
open
Author
renovate
Labels
PR: Dependencies
Created
Updated
Closed
—

Current evaluation

Renovate PR updating eslint from 10.13.0 to 10.14.0. CI has 2 failing legacy-rock tests unrelated to eslint. Automerge enabled.

Suggested action: needs review

Reason: Standard Renovate dependency update (eslint 10.13.0→10.14.0) with minimal diff (+29/-29 lines). CI shows 2 failing tests (run-rockcraft-pack-action-legacy-rock on ubuntu-24.04) that appear unrelated to eslint changes, suggesting pre-existing issues. Requires maintainer review to confirm the failures are not regressions before automerge.

Evaluated by: mr-cal-bot

Impact: 20 Quick Win: 11 Complexity: 10 Confidence: 75 Actionability: 60

Issue body

This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [eslint](https://eslint.org) ([source](https://redirect.github.com/eslint/eslint)) | [`10.13.0` → `10.14.0`](https://renovatebot.com/diffs/npm/eslint/10.13.0/10.14.0) | ![age](https://developer.mend.io/api/mc/badges/age/npm/eslint/10.14.0?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/eslint/10.13.0/10.14.0?slim=true) | --- ### Release Notes <details> <summary>eslint/eslint (eslint)</summary> ### [`v10.14.0`](https://redirect.github.com/eslint/eslint/releases/tag/v10.14.0) [Compare Source](https://redirect.github.com/eslint/eslint/compare/v10.13.0...v10.14.0) #### Features - [`d23a7f9`](https://redirect.github.com/eslint/eslint/commit/d23a7f9eed78e2733fa2d17d7d7dbb9891bbb692) feat: fix property descriptor handling in `func-name-matching` ([#&#8203;21400](https://redirect.github.com/eslint/eslint/issues/21400)) (xbinaryx) #### Bug Fixes - [`4a12580`](https://redirect.github.com/eslint/eslint/commit/4a12580eefdb240bd9b6ae83428638120e9a5f66) fix: require minimatch `10.2.6` to avoid vulnerable brace-expansion ([#&#8203;21460](https://redirect.github.com/eslint/eslint/issues/21460)) (lumir) - [`827a8f3`](https://redirect.github.com/eslint/eslint/commit/827a8f3cca710d3efd76c1d7088d894deff08434) fix: `no-restricted-globals` crash on global objects as property values ([#&#8203;21449](https://redirect.github.com/eslint/eslint/issues/21449)) (xbinaryx) - [`161558a`](https://redirect.github.com/eslint/eslint/commit/161558ae1391a8649a8d69a8b2c2e555b40121b9) fix: handle LS, PS and empty hashbang comments ([#&#8203;21419](https://redirect.github.com/eslint/eslint/issues/21419)) (lumir) - [`6194939`](https://redirect.github.com/eslint/eslint/commit/6194939873960e605b9df3892aa1f5acd648df34) fix: `no-invalid-this` crash on `accessor` fields without initializer ([#&#8203;21442](https://redirect.github.com/eslint/eslint/issues/21442)) (xbinaryx) - [`9155e14`](https://redirect.github.com/eslint/eslint/commit/9155e14781bf0a5549f9a747691f7d98c8c66dcd) fix: Update [@&#8203;humanfs/node](https://redirect.github.com/humanfs/node) dependency version ([#&#8203;21434](https://redirect.github.com/eslint/eslint/issues/21434)) (Nicholas C. Zakas) - [`cb2b9d4`](https://redirect.github.com/eslint/eslint/commit/cb2b9d47a1a14e287ffd473083e97370801ea21e) fix: avoid invalid object-shorthand fixes for super methods ([#&#8203;21323](https://redirect.github.com/eslint/eslint/issues/21323)) (dvd233) - [`5ee3915`](https://redirect.github.com/eslint/eslint/commit/5ee39156b5abb606170a289844cd25aebda6d302) fix: yoda invalid autofix at statement start ([#&#8203;21424](https://redirect.github.com/eslint/eslint/issues/21424)) (Daniel Pinto) #### Documentation - [`0f94f47`](https://redirect.github.com/eslint/eslint/commit/0f94f47b3cf188534d6ac24c0ef4108dd004492b) docs: remove `zh-hans` from docs language switcher ([#&#8203;21437](https://redirect.github.com/eslint/eslint/issues/21437)) (lumir) - [`dab466e`](https://redirect.github.com/eslint/eslint/commit/dab466e5cd43f4b9156a4d00b3423be2ed0088cc) docs: Update README (GitHub Actions Bot) - [`97431f8`](https://redirect.github.com/eslint/eslint/commit/97431f86d5dc7cd60ade6415393b906cf08fe46c) docs: replace `--rulesdir` with a virtual plugin in custom rules docs ([#&#8203;21452](https://redirect.github.com/eslint/eslint/issues/21452)) (Pixel) - [`7697550`](https://redirect.github.com/eslint/eslint/commit/76975502cb1370f2ae4d9427fa1daf7effabe909) docs: Update README (GitHub Actions Bot) - [`0c699d5`](https://redirect.github.com/eslint/eslint/commit/0c699d52d2c4596a56e8f8aa0c8f5732558cf552) docs: Remove Tidelift commercial support ([#&#8203;21416](https://redirect.github.com/eslint/eslint/issues/21416)) (Milos Djermanovic) - [`0880666`](https://redirect.github.com/eslint/eslint/commit/088066663aae84ad6edfa902a27a90c4c08785f3) docs: update loadESLint() documentation for v10 ([#&#8203;21374](https://redirect.github.com/eslint/eslint/issues/21374)) (Minseon Kim) - [`e06fe87`](https://redirect.github.com/eslint/eslint/commit/e06fe87c41cc6210269260a097c61cefb92f456a) docs: Revise AI acknowledgment options in PR template ([#&#8203;21414](https://redirect.github.com/eslint/eslint/issues/21414)) (Nicholas C. Zakas) #### Chores - [`0e2ab70`](https://redirect.github.com/eslint/eslint/commit/0e2ab702714a66829fe2798c77190b48a3a88645) ci: disable `eslint-plugin-unicorn` ecosystem test ([#&#8203;21462](https://redirect.github.com/eslint/eslint/issues/21462)) (Francesco Trotta) - [`6e3f988`](https://redirect.github.com/eslint/eslint/commit/6e3f9888cca518fbb9ba399e88b3033577d9f4ad) chore: update github/codeql-action action to v4.39.1 ([#&#8203;21450](https://redirect.github.com/eslint/eslint/issues/21450)) (renovate\[bot]) - [`a031c40`](https://redirect.github.com/eslint/eslint/commit/a031c40da3c2185279ca8f1f7961fff01fb7b8ff) chore: update ecosystem plugins ([#&#8203;21445](https://redirect.github.com/eslint/eslint/issues/21445)) (ESLint Bot) - [`67d2ca2`](https://redirect.github.com/eslint/eslint/commit/67d2ca2d246bf0311d4a60f58282a7b246c44cba) chore: add troubleshooting page URL to circular fixes warning message ([#&#8203;21429](https://redirect.github.com/eslint/eslint/issues/21429)) (Milos Djermanovic) - [`276021d`](https://redirect.github.com/eslint/eslint/commit/276021d5190f62c873002f7aa08cdcb345135bbe) chore: update github/codeql-action action to v4.39.0 ([#&#8203;21432](https://redirect.github.com/eslint/eslint/issues/21432)) (renovate\[bot]) - [`449724e`](https://redirect.github.com/eslint/eslint/commit/449724e95bfa013fa32c29375925b4111d3924e4) chore: update ecosystem plugins ([#&#8203;21420](https://redirect.github.com/eslint/eslint/issues/21420)) (ESLint Bot) - [`8ffeb8c`](https://redirect.github.com/eslint/eslint/commit/8ffeb8c023bea91a5cfa01b1413a52a83838a59a) chore: update dependency prettier to v3.9.10 ([#&#8203;21417](https://redirect.github.com/eslint/eslint/issues/21417)) (renovate\[bot]) </details> --- ### Configuration 📅 **Schedule**: (in timezone Etc/UTC) - Branch creation - "every weekend" - Automerge - "after 1 am and before 7 am" 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/canonical/craft-actions). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xODguMiIsInVwZGF0ZWRJblZlciI6IjQ0LjE4OC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJQUjogRGVwZW5kZW5jaWVzIl19-->

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b
Impact: 20
Quick Win: 11
Complexity: 10
Confidence: 75
Actionability: 60
needs review Renovate PR updating eslint from 10.13.0 to 10.14.0. CI has 2 failing legacy-rock tests unrelated to eslint. Automerge enabled.

Update history

Date Change
created

Related issues

Issue Project State Summary Similarity
#24 chore(deps): update dependency eslint to v9 craft-actions closed ESLint 9 PR #24 was closed unmerged after package-lock ERESOLVE and failing CI; Renovate marked the 9.x update ignored. Later #63 moved the repo to pnpm/flat config, now on ESLint 10.
82%
#23 chore(deps): update dependency eslint to v9 - autoclosed craft-actions closed Renovate's ESLint 9 update in #23 was autoclosed unmerged after package-lock generation hit ERESOLVE with @typescript-eslint/eslint-plugin 7.7.1.
78%
#134 chore(deps): update development dependencies (minor and patch) craft-actions merged Merged automated dependency update for eslint, typescript-eslint, and vitest to latest minor/patch versions via Renovate.
76%
#76 chore(deps): update development dependencies (minor and patch) craft-actions merged Renovate PR #76 bumping dev deps (@types/node 26.1.1, eslint 10.7.0, prettier 3.9.5, typescript-eslint 8.63.0, vitest 4.1.10) was approved and merged into main; all CI checks passed.
76%
#103 chore(deps): update development dependencies (minor and patch) craft-actions merged Merged #103 via commit fd2c656, updating @types/node to 26.4.0, ESLint to 10.9.1, and typescript-eslint to 8.68.0; all CI checks passed.
74%
#125 chore(deps): update development dependencies (minor and patch) craft-actions closed Renovate updates for @types/node, Prettier, typescript-eslint, and Vitest were merged via commit 68553fe; all CI checks passed.
74%
#128 chore(deps): update development dependencies (minor and patch) craft-actions merged Merged Renovate PR #128 updating dev dependencies: @types/node 26.6.3→26.6.4, eslint 10.11.0→10.12.0, typescript-eslint 8.70.1→8.71.0, vitest 5.0.2→5.0.3.
74%
#91 chore(deps): update development dependencies (minor and patch) craft-actions merged Renovate PR canonical/craft-actions#91 bumped dev deps esbuild 0.28.1→0.28.2 and typescript-eslint 8.66.0→8.67.0 in package.json; approved and merged into main (automerge).
73%
#70 chore(deps): update development dependencies (minor and patch) craft-actions merged Renovate dev-dependency bump in craft-actions (@types/node 26.1.0, eslint 10.6.0, prettier 3.9.4, typescript-eslint 8.62.1) passed CI and was auto-merged into main via commit f1f266b.
73%
#119 chore(deps): update development dependencies (minor and patch) craft-actions merged Renovate dev-dependency PR canonical/craft-actions#119 merged into main via commit c0a51eb, bumping @types/node 26.5.1→26.6.2, eslint 10.10.0→10.11.0, prettier 3.9.6→3.9.8 and vitest 5.0.0→5.0.1; all CI checks passed.
73%