← Back to issue list

snapcraft/pack@v1 should be able to generate a manifest

View original Github issue

Metadata

Project
craft-actions
Number
#148
Type
issue
State
open
Author
jhenstridge
Labels
—
Created
Updated
Closed
—

Current evaluation

No evaluation has been recorded for this issue yet.

Issue body

When debugging a snap, it is useful to have a manifest included in the snap (i.e. the `snap/snapcraft.yaml` and `snap/manifest.yaml` files), as it describes how the snap was built and what versions any `stage-packages` or `stage-snaps` files might be. In the old snapcore/action-build action, this was achieved by setting the `SNAPCRAFT_BUILD_INFO` and `SNAPCRAFT_IMAGE_INFO` environment variables: https://github.com/canonical/action-build/blob/3bdaa03e1ba6bf59a65f84a751d943d549a54e79/src/build.ts#L65-L68 Only the `SNAPCRAFT_BUILD_INFO` one was necessary, but the second was useful to include a reference to the CI run in the resulting snap. As this could contain sensitive information for proprietary snaps, I included a `build-info` input to the action to control this. I defaulted it to true though, and I'm not sure if anyone ever turned it off. Perhaps a better heuristic would be to check whether the repository that triggered the workflow is private. I think the `repository.private` property in the event payload should give this information. One thing to keep in mind when passing environment variables to Snapcraft is the sudo-rs issue described in #147. This would need to be explicit rather than depending on `--preserve-env`.

Evaluation history

No evaluation history available.

Update history

Date Change
created

Related issues

No embedding available for this issue yet. Run scripts/run_llm.py evaluate to enable similarity search.