← Back to issue list

feat: strict platform name validation

View original Github issue

Metadata

Project
craft-application
Number
#1011
Type
pull request
State
open
Author
lengau
Labels
—
Created
Updated
Closed
—

Current evaluation

Adds strict platform name validation via craft-platforms validator, skipping legacy bases (ubuntu 20.04-24.04). 216/13 lines across 10 files. Pending review, 1 unresolved comment, 4 failing CI jobs (fast tests, min deps, lint).

Suggested action: needs review

Reason: The PR has 1 unresolved review comment and 4 failing CI jobs (fast tests on ubuntu-22.04/24.04, minimum dependencies, lint/files), indicating it needs maintainer attention before it can be merged. The author is a maintainer and the feature aligns with the project's existing platform validation work (reserved names #936, slash ban #947), but the failing CI and unresolved comment mean it is not ready to land.

Impact: 50 Quick Win: 27.5 Staleness: 55 Complexity: 45 Confidence: 60

Issue body

This implements strict platform name validation using the validator in craft-platforms (see: https://github.com/canonical/craft-platforms/pull/209) By default, projects only get validated if their base doesn't match any of our "legacy" bases (ubuntu 20.04-24.04). - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 50
Quick Win: 27.5
Staleness: 55
Complexity: 45
Confidence: 60
needs review Adds strict platform name validation via craft-platforms validator, skipping legacy bases (ubuntu 20.04-24.04). 216/13 lines across 10 files. Pending review, 1 unresolved comment, 4 failing CI jobs (fast tests, min deps, lint).
qwen/qwen3.6-35b-a3b
Staleness: 80
Complexity: 40
Confidence: 70
needs review Implements strict platform name validation via craft-platforms, skipping legacy bases by default. Currently pending maintainer review with one unresolved comment and several failing CI checks.
qwen3.6-35b-a3b-mtp-q6
Staleness: 68
Complexity: 42
Confidence: 62
needs review Implements strict platform name validation using craft-platforms, skipping legacy bases by default. Currently inactive for ~4 months with no comments or review.
qwen3.6-35b-a3b-mtp-q6
Staleness: 75
Complexity: 30
Confidence: 60
needs review Implements strict platform name validation using craft-platforms, skipping legacy Ubuntu bases by default. All pre-merge checks passed but the contribution has seen no activity or comments in over 100 days and awaits review.

Update history

No update history recorded yet.

Related work

  • Related To: craft-application#947 (confidence 80%)

    Prior PR that banned '/' in platform names; this PR extends platform name validation with stricter rules from craft-platforms.

  • Related To: craft-application#936 (confidence 75%)

    Added reserved platform names; this PR builds on the same validation infrastructure in craft_application/models/platforms.py.

Related issues

Issue Project State Summary Similarity
#947 feat!(platforms): prevent use of '/' in platform names craft-application merged Prevents use of '/' in platform names, resolving issue #941 and CRAFT-4876. Merged after approval by two reviewers and passing all CI checks across four modified files.
75%
#302 feat!: validate devel bases craft-application merged Merged implementation of devel base validation for craft applications. Approved by reviewers, passed CI checks, and updated to target Ubuntu 24.10. Resolves #298 with 324 additions and 98 deletions across nine files.
71%
#2590 docs: add platform naming rules charmcraft merged Merged documentation update adding platform naming rules from craft-application. Approved by two reviewers. Integrated despite non-blocking CI test failures and type checker notifications.
71%