← Back to issue list

feat: strict platform name validation

View original Github issue

Metadata

Project
craft-application
Number
#1011
Type
pull request
State
open
Author
lengau
Labels
—
Created
Updated
Closed
—

Current evaluation

Adds conditional strict platform-name validation via craft-platforms, exempting legacy Ubuntu 20.04–24.04 bases; remains open with failing fast, minimum-dependency, and lint checks plus one unresolved thread.

Suggested action: keep open

Reason: Four checks are failing, and the fast test validates '/' while asserting an error about '.', leaving an unresolved review thread. Although there has been no activity for 210 days, main still lacks the craft-platforms validator integration, so the change is not demonstrably superseded and should remain open pending fixes.

Evaluated by: mr-cal-bot

Impact: 50 Quick Win: 4 Complexity: 45 Confidence: 92 Actionability: 16

Issue body

This implements strict platform name validation using the validator in craft-platforms (see: https://github.com/canonical/craft-platforms/pull/209) By default, projects only get validated if their base doesn't match any of our "legacy" bases (ubuntu 20.04-24.04). - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 50
Quick Win: 4
Complexity: 45
Confidence: 92
Actionability: 16
keep open Adds conditional strict platform-name validation via craft-platforms, exempting legacy Ubuntu 20.04–24.04 bases; remains open with failing fast, minimum-dependency, and lint checks plus one unresolved thread.
qwen/qwen3.6-35b-a3b
Impact: 45
Quick Win: 6
Complexity: 35
Confidence: 75
Actionability: 20
keep open Implements strict platform name validation using craft-platforms validator. PR has failing CI (Fast tests, Minimum dependencies, lint), 0 reviewers, 1 unresolved review comment, and a test bug (tests '/' but expects error about '.').
qwen/qwen3.8-27b
Impact: 50
Quick Win: 28
Staleness: 55
Complexity: 45
Confidence: 60
needs review Adds strict platform name validation via craft-platforms validator, skipping legacy bases (ubuntu 20.04-24.04). 216/13 lines across 10 files. Pending review, 1 unresolved comment, 4 failing CI jobs (fast tests, min deps, lint).
qwen/qwen3.6-35b-a3b
Staleness: 80
Complexity: 40
Confidence: 70
needs review Implements strict platform name validation via craft-platforms, skipping legacy bases by default. Currently pending maintainer review with one unresolved comment and several failing CI checks.
qwen3.6-35b-a3b-mtp-q6
Staleness: 68
Complexity: 42
Confidence: 62
needs review Implements strict platform name validation using craft-platforms, skipping legacy bases by default. Currently inactive for ~4 months with no comments or review.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#209 feat: validate platform names craft-platforms merged Merged PR #209 (commit 2a92a08): get_build_plan now validates platform names and a new craft_platforms.validators/platform_types module offers validation helpers. Shipped in craft-platforms 0.11.0.
73%