Verify architecture inclusion in craft-providers instance naming
Metadata
Current evaluation
Closed unchanged after confirming #1027’s architecture-aware base names and craft-providers auto_clean prevent cross-architecture working-instance collisions.
Resolution: closed not a bug
Reason: #1040 was closed with a zero-file diff after finding no naming defect: architecture is embedded in base-instance image names, while auto_clean removes incompatible working instances. Merged commit 15f48281 in #1027 already supplied the relevant instance_architecture handling.
Evaluated by: mr-cal-bot
No scores available.
Issue body
A review comment on #1027 raised a concern that introducing `instance_architecture` could cause working instance name collisions when the same platform is built with different architectures (e.g. via `CRAFT_BUILD_ON`). A follow-up question asked whether craft-providers already addresses this via architecture-aware instance naming.
## Findings
After reviewing [`lxd_provider.py`](https://github.com/canonical/craft-providers/blob/2a25ff8ac8ededaa35a0f12c0393a34257c815d9/craft_providers/lxd/lxd_provider.py) and `launcher.py`:
- **Base instance names** (`base-instance-{tag}-{remote}-{image_name}`) **do** embed architecture, since `image_name` is set to `"{image}/{arch}"` when `instance_architecture` is provided.
- **Working instance names** are passed through unchanged from craft-application — architecture is not appended by craft-providers.
- Name collisions on working instances are **already mitigated** by `auto_clean=True`: if `launch()` finds an existing instance that fails the compatibility warmup (e.g. wrong arch), it deletes it and rebuilds from the correct arch-specific base instance.
## Conclusion
No changes to `_get_instance_name` are needed. The concern is handled gracefully at the craft-providers layer.
<!-- START COPILOT CODING AGENT TIPS -->
---
✨ Let Copilot coding agent [set things up for you](https://github.com/canonical/craft-application/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed not a bug | Closed unchanged after confirming #1027’s architecture-aware base names and craft-providers auto_clean prevent cross-architecture working-instance collisions. | |
| stealth/space-bunny-alpha | — | closed not a bug | Closed #1040 with no code change: architecture-specific base names and auto_clean already prevent cross-architecture instance conflicts; #1027 was merged in 15f48281. | |
| stealth/space-bunny-alpha | — | closed not a bug | PR #1040 closed without changes after confirming architecture-specific base names and auto_clean mitigate cross-architecture instance collisions; #1027 was merged in commit 15f48281. | |
| stealth/space-bunny-alpha | — | closed not a bug | Closed without changes: #1040 confirmed #1027 (commit 15f48281) already avoided architecture naming collisions via architecture-specific base names and auto-clean behavior. | |
| stealth/space-bunny-alpha | — | closed not a bug | Closed #1040 with no code changes: architecture-specific base names and auto_clean already mitigate cross-architecture working-instance collisions; merged #1027 needed no naming change. | |
| qwen/qwen3.6-35b-a3b | — | — | Investigated potential architecture-based instance naming collisions. Found base instances already embed architecture and conflicts are auto-resolved via auto_clean. Closed without changes as the concern is already handled gracefully. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without changes. Review confirmed craft-providers already embeds architecture in base instance names and resolves collisions via auto_clean=True. Existing logic handles the concern, requiring no modifications. |
Update history
No update history recorded yet.
Related work
-
Caused By:
canonical/craft-application#1027
(confidence 100%)
Merged as commit 15f48281; review of its architecture support prompted this verification.
Related issues
No related issues found above the similarity threshold.