← Back to issue list

refactor: drop _Dispatcher

View original Github issue

Metadata

Project
craft-application
Number
#106
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #106 as commit 3cf5c8a4, removing the internal _Dispatcher and requiring craft-cli 2.3.0 for Dispatcher.parsed_args().

Resolution: closed resolved

Reason: PR #106 was merged into main as commit 3cf5c8a4. It dropped _Dispatcher and updated the minimum craft-cli dependency to 2.3.0.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Update the minimum version of craft-cli to 2.3.0, in which the standard Dispatcher class has the ``parsed_args()`` method which we can use instead. - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #106 as commit 3cf5c8a4, removing the internal _Dispatcher and requiring craft-cli 2.3.0 for Dispatcher.parsed_args().
stealth/space-bunny-alpha — closed resolved Merged PR #106 as commit 3cf5c8a4, removing the internal _Dispatcher and requiring craft-cli 2.3.0 to use Dispatcher.parsed_args().
qwen/qwen3.6-35b-a3b — — Merged a refactoring that drops the internal _Dispatcher class. Updates craft-cli minimum version to 2.3.0 to leverage its standard Dispatcher.parsed_args() method. Approved by two reviewers, passed CI, and merged successfully.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#563 Improved the Dispatcher to work with default global args and support extra ones in the future (CRAFT-565). charmcraft merged Merged PR #563 as 6c9a6e03 (head 6e26aa82), improving Dispatcher global-argument handling, adding tests, and relocating help logic for craft-cli extraction.
77%