← Back to issue list

refactor: drop _Dispatcher

View original Github issue

Metadata

Project
craft-application
Number
#106
Type
pull request
State
merged
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Merged a refactoring that drops the internal _Dispatcher class. Updates craft-cli minimum version to 2.3.0 to leverage its standard Dispatcher.parsed_args() method. Approved by two reviewers, passed CI, and merged successfully.

Suggested action:

No scores available.

Issue body

Update the minimum version of craft-cli to 2.3.0, in which the standard Dispatcher class has the ``parsed_args()`` method which we can use instead. - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a refactoring that drops the internal _Dispatcher class. Updates craft-cli minimum version to 2.3.0 to leverage its standard Dispatcher.parsed_args() method. Approved by two reviewers, passed CI, and merged successfully.
qwen3.6-35b-a3b-mtp-q6 Merged a refactor dropping the custom _Dispatcher class. Updates craft-cli minimum version to 2.3.0 to use its built-in Dispatcher.parsed_args() method. Coverage decreased by 0.01% with 100% diff coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#563 Improved the Dispatcher to work with default global args and support extra ones in the future (CRAFT-565). charmcraft merged Merged Dispatcher improvements for default global arguments and future extras. Refactored naming, relocated help functions, and prepared code for craft-cli extraction. Approved and merged.
77%
#56 Simplify the Dispatcher usage craft-cli open Refactor request to simplify craft-cli Dispatcher usage by adding a simple_run helper or implicit pre_parse_args/load_command calls before run. Triaged by maintainer, synced to internal ticket CRAFT-4790, but no code change implemented yet.
74%
#1520 refactor: remove old "init" command implementation charmcraft merged Merged a refactoring PR removing the old "init" command after the craft-application transition. Approved by two reviewers with passing CI, the change modified four files, adding one line and deleting 248.
70%