← Back to issue list

feat: add a mechanism to add fetch-service secrets

View original Github issue

Metadata

Project
craft-application
Number
#1066
Type
pull request
State
merged
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Merged the feature adding FetchService.register_secret_callback(), enabling applications and plugins to dynamically register secret providers triggered before fetch-service session creation. Approved by two reviewers and passed CI checks.

Suggested action:

No scores available.

Issue body

Applications and plugins can use FetchService.register_secret_callback() to register a callable that is triggered when we're about to create a new fetch-service session. This callable can then return secrets following the fetch-service's own API. - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged the feature adding FetchService.register_secret_callback(), enabling applications and plugins to dynamically register secret providers triggered before fetch-service session creation. Approved by two reviewers and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged a feature enabling apps and plugins to dynamically supply secrets for fetch-service sessions via FetchService.register_secret_callback(). The callable runs before session creation to return credentials.
qwen3.6-35b-a3b-mtp-q6 Merged a feature allowing applications and plugins to register a callback via FetchService.register_secret_callback(). The callback dynamically supplies secrets prior to creating new fetch-service sessions.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#272 feat: add fetch-service version to session metadata fetch-service merged Merged after approval from two reviewers and passing CI. Introduces a generator key to session metadata to explicitly track the fetch-service version, resolving issue #258.
74%