fix: handle `--debug` for post-prime failures
Metadata
Current evaluation
Merged PR #1073 (commit 38fdb686) preserves --debug shell handling when post-prime actions such as Snapcraft pack fail, fixing #1074.
Resolution: closed resolved
Reason: Merged PR #1073 added debug error handling around post-prime steps so failures launch a shell before the error is re-raised. Commit 38fdb686 records the resolution of #1074.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Fixes an exception when trying to launch a shell in the case where `--debug` is used and a post-prime action fails. An example case in Snapcraft is when a build succeeds but `pack` fails due to missing required metadata fields. (Presence of required fields cannot always be validated earlier, because one could use `parse-info` to read them from a build output file).
Fixes canonical/craft-application#1074.
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint && make test`?
- [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1073 (commit 38fdb686) preserves --debug shell handling when post-prime actions such as Snapcraft pack fail, fixing #1074. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1073 (commit 38fdb686) fixes --debug shell handling when post-prime actions such as Snapcraft pack fail, resolving #1074. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged fix preserves --debug/--shell handling when post-prime actions, including Snapcraft pack, fail, resolving canonical/craft-application#1074. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix resolving an exception when launching a debug shell after post-prime failures. Approved by three reviewers and passed CI checks. Resolves craft-application#1074 with 48 additions and 2 deletions across two files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for an exception when launching a debug shell after a post-prime action failure. Resolves canonical/craft-application#1074 by properly handling debug mode during post-prime errors. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/craft-application#1074
(confidence 100%)
The PR explicitly fixes the late pack failure involving --shell and --debug.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4959 `--debug` does not enter a shell for failures during post-prime or packing | snapcraft | closed | Fixed in Snapcraft 8.4.1: core24 --debug now opens a shell after post-prime or packing failures via craft-application PR #436 (ab55ec81). | |
| #1074 --shell and --debug fail cryptically with late pack failures | craft-application | closed | Fixed in merged PR #1073 (commit 38fdb686), which added post-prime failure handling so --debug can open a shell instead of only reporting an instance error. | |
| #415 `--debug` does not enter a shell for failures during post-prime or packing | craft-application | closed | Fixed by merged PR #436 (commit ab55ec81), adding --shell/--shell-after to pack and making --debug drop into a shell when packing fails; closed by maintainer tigarmo on 2024-09-10. |