fix(remote): deduplicate artifact names in remote-build success message
Metadata
Current evaluation
Fixes duplicate artifact names in remote-build success message by deduplicating via set comprehension. Author acknowledges current approach masks root cause and is working on filtering by build request ID instead.
Suggested action: keep open
Reason: The PR author actively acknowledged review feedback (2 unresolved comments) and stated they are working on a better fix that filters by build request ID rather than deduplicating filenames. Last activity was 6 days ago, indicating ongoing development. The PR addresses open issue #1093 and has not been superseded.
Impact:
35
Quick Win:
19.25
Staleness:
45
Complexity:
45
Confidence:
75
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint && make test`?
- [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
## Summary
When `remote-build` is run multiple times, Launchpad returns historical
builds with different URLs but the same output filenames. Since
`artifact_downloads` keys on URL, duplicates slip through into `.values()`,
causing the success message to list the same snap multiple times.
## Fix
Deduplicate artifact names using a set comprehension before sorting:
artifact_names = sorted({path.name for path in artifacts})
## Test
Added a regression test that mocks `fetch_artifacts` to return duplicate
filenames and asserts each artifact appears only once in the success message.
Fixes #1093
Related: canonical/snapcraft#6230
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen3.6-35b-a3b-mtp-q6 |
Impact:
35
Quick Win:
19.25
Staleness:
45
Complexity:
45
Confidence:
75
|
keep open | Fixes duplicate artifact names in remote-build success message by deduplicating via set comprehension. Author acknowledges current approach masks root cause and is working on filtering by build request ID instead. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
45
Complexity:
20
Confidence:
85
|
keep open | Deduplicates artifact names in remote-build success message. Currently a temporary workaround; author is implementing a proper fix by filtering historical builds via request ID and will update the PR shortly. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
15
Complexity:
30
Confidence:
85
|
keep open | Deduplicates artifact names in remote-build success message using a set comprehension. Author acknowledges this masks the root cause and is implementing a proper fix filtering by build request ID. Currently under active development. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
5
Complexity:
15
Confidence:
90
|
needs review | Fixes remote-build success message showing duplicate artifact names by deduplicating paths before sorting. Includes regression test and changelog entry. Currently awaiting maintainer review. |
Update history
| Date | Change |
|---|---|
| updated |
Related work
-
Related To:
canonical/snapcraft#6230
(confidence 90%)
Closed as duplicate; explicitly references this craft-application issue and PR as the fix location.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1093 remote-build success message lists duplicate artifact names | craft-application | open | Duplicate artifact names in remote-build success message due to URL-keyed dict not deduplicating by filename. Valid bug with open PR craft-application#1094 addressing it. |