← Back to issue list

ci: fix OSV-scanner workflow path and exclude docs-only inputs

View original Github issue

Metadata

Project
craft-application
Number
#1130
Type
pull request
State
merged
Author
Copilot
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1130 as commit 235a5cc0, correcting the OSV config path and excluding docs paths and docs-only dependency groups from security scans.

Resolution: closed resolved

Reason: PR #1130 was merged as commit 235a5cc0. The passing Security scan / OSV-scanner check confirms the workflow now uses the correct config path and applies the intended exclusions.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The `Security scan / OSV-scanner` job was failing because the workflow passed a config path that no longer existed from the scanner's working directory. This change aligns `craft-application` with the Starbase scanner wiring, then scopes the scan away from docs-only dependency inputs that are not part of the shipped application surface. - **Root cause** - `scan-python.yaml` runs OSV inside `source/`, but this repository passed `--config=source/.osv-scanner.toml`. - That resolved to a non-existent path at runtime, causing the scanner to fail before evaluating dependencies. - **Starbase parity** - Move the scanner config from `.osv-scanner.toml` to `osv-scanner.toml`. - Update the workflow to pass `--config=osv-scanner.toml`, matching the current Starbase integration pattern. - **Repository-specific OSV scope** - Exclude `docs/` from the recursive source scan. - Exclude the `docs` and `docs-starter-pack` dependency groups from exported requirements scanning. - Keep the existing ignored vulnerability entry in the relocated config file. - **Resulting workflow shape** ```yaml with: uv-export-extra-args: "--extra remote" osv-extra-args: "--config=osv-scanner.toml" osv-exclude-paths: | docs uv-export-no-groups: | docs docs-starter-pack ```

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1130 as commit 235a5cc0, correcting the OSV config path and excluding docs paths and docs-only dependency groups from security scans.
stealth/space-bunny-alpha — closed resolved Merged PR #1130 (commit 235a5cc0), fixing the OSV-scanner config path and excluding docs-only paths and dependency groups from the scan.
qwen/qwen3.6-35b-a3b — — Merged. Corrected the OSV-scanner workflow config path to align with Starbase and excluded docs from scanning. Updated the uv lockfile for httplib2 and setuptools to resolve scanner failures. All CI checks passed.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 10
Confidence: 90
needs review Fixes failing OSV-scanner CI by correcting config path and excluding docs dependencies. Approved by two reviewers, CI mostly passing, ready for maintainer review and merge.
qwen3.6-35b-a3b-mtp-q6
Staleness: 0
Complexity: 15
Confidence: 90
needs review Fixes failing OSV-scanner CI workflow by correcting config path and excluding docs. Incorporates maintainer-requested lockfile updates. Ready for maintainer review.

Update history

Date Change
updated

Related issues

Issue Project State Summary Similarity
#1299 ci: fix osv scanner on docs rockcraft merged Merged PR #1299 via commit c0191bb5, configuring OSV Scanner to ignore documentation-derived content and fix docs security scanning.
87%
#988 ci: fix OSV scanner policy workflow craft-providers merged Merged as e6a3482: updated OSV scanner inputs and config, excluded docs paths/groups, and added osv-scanner.toml. All CI checks passed.
84%
#654 ci: exclude docs from security scan fetch-service closed Merged as commit 03ce591: adds `osv-exclude-paths: "docs/"` to .github/workflows/security-scan.yaml so the starflow OSV-scanner job stops failing on docs/requirements.txt (idna via canonical-sphinx).
81%
#508 ci: restore osv-scanner configuration in policy workflow craft-cli closed Merged PR #508 to restore OSV-scanner configuration in `.github/workflows/policy.yaml`, excluding `docs` from scans to prevent false positive vulnerability reports.
78%
#5487 ci: remove config for osv scanner snapcraft merged Merged PR #5487 as commit 866694712, removing four lines of resolved, expired OSV scanner configuration from CI.
78%
#962 ci: ignore sample files in OSV scans rockcraft merged Merged PR #962 as commit e9b702cb to exclude documentation and spread-test sample files from OSV scans, avoiding findings for demo-only vulnerable versions.
78%
#6347 ci(scan): fix osv scanner on docs snapcraft merged Merged in snapcraft#6347 as 5bb3aff7d, porting starbase#573 to add OSV exclusions so documentation inputs no longer fail security scanning.
77%
#1640 ci: align policy OSV scanner inputs craft-parts merged PR #1640 merged as commit 159bad0d, aligning .github/workflows/policy.yaml OSV inputs with starbase #573: added osv-extra-args/exclude-paths, uv-export-no-groups, removed requirements-find-args, added root osv-scanner.toml.
76%
#2951 ci: exclude tests from OSV source scan charmcraft merged Merged PR #2951 (commit 5dc3fd6c) excluded test directories from OSV source scanning, removing test requirements and lock files; paired with merged dependency update #2950.
76%
#2821 ci: fix osv workflow errors charmcraft merged Merged as commit 67922e47; repaired the OSV security workflow and updated cryptography to resolve the reported OSV finding.
75%