← Back to issue list

fix: don't package projects with no parts

View original Github issue

Metadata

Project
craft-application
Number
#1164
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1164 (squash commit dc14f0e1, CRAFT-4693) skips package creation when a project defines no parts; approved by 2 reviewers with all CI checks green.

Resolution: closed resolved

Reason: The PR itself was merged into the main branch as commit dc14f0e1 ("fix: don't package projects with no parts (#1164)"), adding a guard to skip packaging for part-less projects (+93/-10 across 4 files).

Evaluated by: mr-cal-bot

No scores available.

Issue body

Skip package creation When a project has no parts defined. - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- CRAFT-4693

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1164 (squash commit dc14f0e1, CRAFT-4693) skips package creation when a project defines no parts; approved by 2 reviewers with all CI checks green.
stealth/space-bunny-alpha — closed resolved Merged craft-application PR #1164 skips package creation for projects with no parts, preventing empty projects from being packaged. Approved by two reviewers with all CI checks passing.
qwen/qwen3.6-35b-a3b — — Merged a fix that skips package creation for projects with no parts. Approved by two reviewers and passed all CI checks, resolving incorrect packaging behavior for empty projects.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 15
Confidence: 90
needs review Skips package creation for projects with no parts defined. Approved by 2 reviewers, CI mostly passing with pending tests, ready for maintainer review/merge.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 15
Confidence: 90
needs review Skips package creation for projects with no parts defined. Currently approved by two reviewers with zero unresolved comments, awaiting final CI completion.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 15
Confidence: 90
needs review Fixes packaging by skipping creation when a project defines no parts. Currently approved by two reviewers, CI passes, but has one unresolved review comment.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 15
Confidence: 90
needs review Skips package creation for projects with no parts defined. Currently approved by two reviewers with all CI checks passing, though one unresolved review comment remains.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 15
Confidence: 95
needs review Fixes packaging behavior to skip creation when a project defines no parts. PR is approved, all CI checks pass, and ready for maintainer merge.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 15
Confidence: 85
needs review Skips package creation for projects with no parts defined. Currently awaiting maintainer review with CI checks still running.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 15
Confidence: 85
needs review Fixes packaging logic to skip creation when a project defines no parts. Currently pending maintainer review with one failing lint check and multiple CI jobs in progress.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 15
Confidence: 85
needs review Skips package creation for projects with no parts defined. Currently pending maintainer review with one unresolved comment and CI checks still running.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 15
Confidence: 90
needs review Skips package creation for projects with no parts defined. Currently pending maintainer review with 0 comments. CI shows a failing lint check and many pending tests.

Update history

Date Change
updated
updated
updated
updated
updated
updated
updated
created

Related work

Related issues

Issue Project State Summary Similarity
#596 build: don't create implicit part if parts section specified (CRAFT-633) charmcraft merged PR #596 merged (merge commit 0dacae0a, bcbdd278) by cmatsuoka: charmcraft now skips the implicit `charm`/`bundle` part when an explicit `parts:` section exists (CRAFT-633), fixing #590; tests added.
71%