← Back to issue list

feat(test): parse <app-name>-test.yaml, deprecate spread.yaml

View original Github issue

Metadata

Project
craft-application
Number
#1168
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

⚠️ This summary may be outdated — the issue content or evaluation prompts have changed since this evaluation was made.

Adds parsing of <app-name>-test.yaml as the test config file and emits a deprecation warning when the legacy spread.yaml is used. Maintainer-authored, approved by 2 reviewers, all completed CI checks passing with some fast/flaky test jobs still pending.

Suggested action: needs review

Reason: The PR is fresh (1 day old, activity 0 days ago), approved by 2 reviewers with 0 unresolved comments, and all completed CI checks pass, so it is ready to be landed per the needs_review criteria. It touches the shared test lifecycle in craft_application/services/testing.py (which currently hardcodes 'spread.yaml' in parse_spread_yaml) plus 15 files, with a deprecation path for existing users, so a final maintainer merge decision is warranted. A few fast/flaky test jobs are still pending, which slightly tempers confidence.

Impact: 55 Quick Win: 27.5 Staleness: 2 Complexity: 50 Confidence: 85

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- Allows parsing `<app-name>-test.yaml` and adds a deprecation warning when parsing existing `spread.yaml`. (CRAFT-5282)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 55
Quick Win: 27.5
Staleness: 2
Complexity: 50
Confidence: 85
needs review Adds parsing of <app-name>-test.yaml as the test config file and emits a deprecation warning when the legacy spread.yaml is used. Maintainer-authored, approved by 2 reviewers, all completed CI checks passing with some fast/flaky test jobs still pending.
qwen/qwen3.8-27b
Impact: 55
Quick Win: 27.5
Staleness: 5
Complexity: 50
Confidence: 85
needs review Adds parsing of <app-name>-test.yaml and a deprecation warning for spread.yaml in the test service (CRAFT-5282). Approved by 2 reviewers, 13 CI checks passing, 11 pending, none failing. +397/-48 across 15 files.
qwen/qwen3.8-27b
Impact: 45
Quick Win: 22.5
Staleness: 5
Complexity: 50
Confidence: 80
needs review Adds parsing of <app-name>-test.yaml as an alternative to spread.yaml for the test command, with a deprecation warning for spread.yaml. 15 files, +398/-46. Approved by 2 reviewers, CI passing, ready to land.
qwen/qwen3.8-27b
Impact: 55
Quick Win: 22.0
Staleness: 5
Complexity: 60
Confidence: 80
needs review Adds parsing of <app-name>-test.yaml as an alternative to spread.yaml for the test command, with a deprecation warning for spread.yaml. Approved by 2 reviewers, CI passing, 4 unresolved review comments remain.
qwen/qwen3.8-27b
Impact: 50
Quick Win: 27.5
Staleness: 5
Complexity: 45
Confidence: 75
needs review Adds parsing of <app-name>-test.yaml and a deprecation warning for spread.yaml in the test command (CRAFT-5282). Approved by 2 reviewers, 5 unresolved review comments, 1 failing CI check (snap-tests openstack), 1 day old.
qwen/qwen3.8-27b
Impact: 45
Quick Win: 22.5
Staleness: 5
Complexity: 50
Confidence: 85
needs review Adds parsing of <app-name>-test.yaml and a deprecation warning for spread.yaml in the test service (CRAFT-5282). Approved by 1 reviewer with 2 unresolved review comments; CI green except the openstack snap-tests job.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 85
needs review Enables parsing <app-name>-test.yaml and deprecates spread.yaml with a warning. Approved by 1 reviewer, has 3 unresolved comments, and one failing CI job.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 35
Confidence: 85
needs review Enables parsing <app-name>-test.yaml and deprecates spread.yaml with a warning. Currently approved by one reviewer, has three unresolved comments, and one failing CI job.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 35
Confidence: 85
needs review Adds support for parsing <app-name>-test.yaml and deprecates spread.yaml parsing. Currently pending maintainer review with 2 unresolved comments and one failing CI check.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 35
Confidence: 85
needs review Adds support for parsing <app-name>-test.yaml and deprecates spread.yaml parsing. Currently pending maintainer review with two unresolved comments and one failing CI check.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 35
Confidence: 90
needs review Enables parsing of app-name-test.yaml and deprecates spread.yaml with a warning. Currently pending maintainer review with unresolved comments and several CI checks still running.
qwen/qwen3.6-35b-a3b
Staleness: 0
Complexity: 45
Confidence: 85
needs review Enables parsing <app-name>-test.yaml and deprecates spread.yaml. Currently pending maintainer review with 4 unresolved comments and 2 failing CI checks.

Update history

Date Change
updated
updated
updated
updated
updated
updated
updated
updated
updated
created

Related issues

No related issues found above the similarity threshold.