← Back to issue list

chore: block snap auto-refreshes during tests

View original Github issue

Metadata

Project
craft-application
Number
#1172
Type
pull request
State
closed
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

PR #1172 (block snap auto-refreshes during tests) was closed unmerged as a duplicate of #1170, which already added a refresh hold and wait in spread prepare (merged as fea3e835).

Resolution: closed superseded

Reason: Maintainer cmatsuoka closed the PR with the comment "Duplicate of #1170", which had already been merged as commit fea3e835 implementing the same snap auto-refresh hold/wait logic in the spread test prepare step. The +3/-0 change here was redundant.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Prevent spread test errors caused by snap refreshes in progress. - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR #1172 (block snap auto-refreshes during tests) was closed unmerged as a duplicate of #1170, which already added a refresh hold and wait in spread prepare (merged as fea3e835).
stealth/space-bunny-alpha — closed superseded Closed unmerged as a duplicate of canonical/craft-application#1170, which blocked snap auto-refreshes and waited out in-progress refreshes to avoid spread-test errors.
qwen3.6-35b-a3b-mtp-q6 — — Closed as a duplicate of #1170. The pull request to block snap auto-refreshes during tests was not merged, as the fix was already implemented elsewhere.

Update history

Date Change
closed
updated
updated
updated
updated
updated
created

Related work

  • Duplicate Of: canonical/craft-application#1170 (confidence 98%)

    Author's closing comment states "Duplicate of #1170"; #1170 added the 24h refresh hold and wait for active auto-refreshes and was merged as fea3e835.

  • Related To: canonical/craft-application#1190 (confidence 70%)

    Later PR targeting the same LXD auto-refresh race in spread prepare; closed unmerged after #1170 landed.

Related issues

Issue Project State Summary Similarity
#1170 test(spread): wait out in-progress auto-refresh in prepare craft-application closed Merged PR #1170 as fea3e835, adding a 24-hour snap refresh hold and waiting for active auto-refreshes to prevent spread prepare races.
72%