← Back to issue list

fix: set mode for the lp-test openstack backend

View original Github issue

Metadata

Project
craft-application
Number
#1216
Type
pull request
State
open
Author
simonepelosi
Labels
—
Created
Updated
Closed
—

Current evaluation

Adds mode to SpreadBackend and sets application-credential for lp-test openstack backend; updates test expectation. CI failing lint/files, no reviews yet.

Suggested action: needs review

Reason: The diff is small and most tests pass, but CI shows lint/files failing and the PR checklist leaves the changelog entry unchecked, so it is not ready to merge until those are addressed.

Evaluated by: mr-cal-bot

Impact: 50 Quick Win: 17 Complexity: 25 Confidence: 70 Actionability: 45

Issue body

The lp-test backend sets type=openstack but never sets mode, so spread defaults to Keystone v3 password auth. The spread fork actually used by bincraft (cmatsuoka/spread@experimental/goose-application-credentials) reads backend.Mode to pick the auth method, accepting "application-credential" (see openstack.go authMode()); this backend is exactly that case (OS_AUTH_TYPE=v3applicationcredential), so wire it through. - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? ---

Evaluation history

Date Model Scores Action Summary
~deepseek/deepseek-pro-latest
Impact: 50
Quick Win: 17
Complexity: 25
Confidence: 70
Actionability: 45
needs review Adds mode to SpreadBackend and sets application-credential for lp-test openstack backend; updates test expectation. CI failing lint/files, no reviews yet.
~deepseek/deepseek-pro-latest
Impact: 50
Quick Win: 29
Complexity: 10
Confidence: 75
Actionability: 65
needs review Adds mode=application-credential to lp-test OpenStack backend so the spread fork selects application-credential auth; updates model, service, and test expectation. Awaiting review.

Update history

Date Change
updated
created

Related issues

No related issues found above the similarity threshold.