← Back to issue list

chore: fix warnings from pytest

View original Github issue

Metadata

Project
craft-application
Number
#1237
Type
pull request
State
open
Author
bepri
Labels
—
Created
Updated
Closed
—

Current evaluation

No evaluation has been recorded for this issue yet.

Issue body

Fixes the following warnings: <details> <summary>Warnings</summary> ``` .venv/lib/python3.10/site-packages/_pytest/python.py:124 /home/runner/work/craft-application/craft-application/.venv/lib/python3.10/site-packages/_pytest/python.py:124: PytestRemovedIn10Warning: Passing a non-Collection iterable to parametrize is deprecated. Test: tests/integration/test_application.py::test_project_managed, argvalues type: generator Please convert to a list or tuple. See https://docs.pytest.org/en/stable/deprecations.html#parametrize-iterators metafunc.parametrize(*marker.args, **marker.kwargs, _param_mark=marker) .venv/lib/python3.10/site-packages/_pytest/python.py:124 /home/runner/work/craft-application/craft-application/.venv/lib/python3.10/site-packages/_pytest/python.py:124: PytestRemovedIn10Warning: Passing a non-Collection iterable to parametrize is deprecated. Test: tests/integration/test_application.py::test_project_destructive, argvalues type: generator Please convert to a list or tuple. See https://docs.pytest.org/en/stable/deprecations.html#parametrize-iterators metafunc.parametrize(*marker.args, **marker.kwargs, _param_mark=marker) craft_application/errors.py:51 /home/runner/work/craft-application/craft-application/craft_application/errors.py:51: PytestCollectionWarning: cannot collect test class 'TestFileError' because it has a __init__ constructor (from: tests/unit/services/test_testing.py) class TestFileError(CraftError): .venv/lib/python3.10/site-packages/_pytest/python.py:124 /home/runner/work/craft-application/craft-application/.venv/lib/python3.10/site-packages/_pytest/python.py:124: PytestRemovedIn10Warning: Passing a non-Collection iterable to parametrize is deprecated. Test: tests/unit/util/test_yaml.py::test_safe_yaml_loader_valid, argvalues type: generator Please convert to a list or tuple. See https://docs.pytest.org/en/stable/deprecations.html#parametrize-iterators metafunc.parametrize(*marker.args, **marker.kwargs, _param_mark=marker) ``` </details> --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/craft-application/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

No evaluation history available.

Update history

Date Change
updated
created

Related issues

No embedding available for this issue yet. Run scripts/run_llm.py evaluate to enable similarity search.