← Back to issue list

fix(remote-build): exit non-zero when any build fails

View original Github issue

Metadata

Project
craft-application
Number
#1243
Type
pull request
State
open
Author
18Abhinav07
Labels
—
Created
Updated
Closed
—

Current evaluation

No evaluation has been recorded for this issue yet.

Issue body

Fixes #989 remote-build returned 0 even when some architectures failed or were cancelled, so CI treated those runs as green. It now lists the architectures that ended as failed, upload failed, chroot problem or cancelled, and returns 1. Superseded builds don't count. Successful runs still exit 0, and logs and artifacts are still downloaded either way. I ran ruff, ty, codespell and the full test suite in a Linux container rather than `make lint && make test`. No new failures: the tests that fail there fail on main too. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/craft-application/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [x] I've updated the relevant release notes.

Evaluation history

No evaluation history available.

Update history

Date Change
updated
created

Related issues

No embedding available for this issue yet. Run scripts/run_llm.py evaluate to enable similarity search.