← Back to issue list

fix(build): only package craft-application/*

View original Github issue

Metadata

Project
craft-application
Number
#133
Type
pull request
State
merged
Author
tigarmo
Labels
Created
Updated
Closed

Current evaluation

Merged a build fix restricting packaging to craft-application/* directories to match Starbase. Approved by three reviewers, passed CI, and caused no coverage change. The single-file update added two and removed six lines.

Suggested action:

No scores available.

Issue body

This corresponds to how Starbase does it - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a build fix restricting packaging to craft-application/* directories to match Starbase. Approved by three reviewers, passed CI, and caused no coverage change. The single-file update added two and removed six lines.
qwen3.6-35b-a3b-mtp-q6 Merged into main. Build configuration updated to only package craft-application/* subdirectories, matching Starbase. Codecov confirmed no coverage change.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1454 build: update craft-application charmcraft merged Merged after updating the craft-application dependency and adjusting test constants. Approved by two reviewers with no unresolved comments. Changes affect three files with minor line adjustments.
81%
#4573 build(deps): use craft-application from main branch snapcraft merged Merged dependency update switching to craft-application from the main branch. Approved by two reviewers, passed CI, and resolved linter and coverage notes. Changes modified 8 files with 65 additions and 45 deletions.
77%
#1563 fix: breaking changes from craft-application main charmcraft merged Merged to resolve breaking changes from craft-application main. Approved by two reviewers, the update modified five files (+46/-26 lines) and was successfully integrated into the codebase.
76%
#5529 fix: remove test artifact workaround snapcraft merged Merged a fix that removes the snapcraft test artifact location workaround, as craft-application 3.5 now handles this natively. Approved by two reviewers, passed all CI checks, and modified five files.
75%
#123 build(deps): update craft-cli and craft-application versions imagecraft merged Merged update to craft-cli and craft-application dependency versions. Approved by two reviewers, passed CI checks, and modified two files with minor version bumps.
75%
#968 build(deps): update craft-application rockcraft merged Merged after updating craft-application for a CRAFT-4705 demo. Approved by two reviewers with most CI checks passing despite failing snap-tests. Changes affect 17 files with 95 additions and 27 deletions.
75%
#1386 fix: final spread test fixes for craft-application charmcraft merged Merged after approval by two reviewers. Resolves final spread test issues for craft-application across seven files, removing 127 lines and adding 104. Changes integrated into the main branch.
75%
#1399 feat: craft-application rebase charmcraft merged Merged the craft-application rebase, altering 109 files with 7,783 additions and 755 deletions. Approved by two reviewers, the update was deemed functional for integration, with remaining issues deferred to future pull requests.
74%
#569 build(deps): bump craft-application to 2.7.0 rockcraft merged Merged after approval from two reviewers and passing CI checks. The change updates the craft-application dependency to version 2.7.0 across seven files.
74%
#4691 build(deps): update craft-application to 2.1.0 snapcraft merged Merged dependency update upgrading craft-application to 2.1.0. Approved by two reviewers, passed CI checks, and maintained full test coverage on modified lines. Changes span four files with a minimal diff.
74%