← Back to issue list

feat: evaluate project using grammar rules

View original Github issue

Metadata

Project
craft-application
Number
#150
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged two-stage project grammar evaluation: first for build-plan discovery, then for the resolved build-on/build-for architectures (craft-application#150, f51c0e3b).

Resolution: closed resolved

Reason: PR canonical/craft-application#150 was approved and merged as commit f51c0e3b. It evaluates grammar twice so architecture-specific parts are resolved correctly while keeping grammar handling transparent to applications.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Grammar evaluation is done for a specific set of build-on/build-for architectures, however those are listed in the build plan which in turn is obtained from the project model. To keep the grammar handling transparent to the application we evaluate grammar twice, first to obtain the build plan, and then to resolve for the correct set of architectures. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? ----- (CRAFT-2322)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged two-stage project grammar evaluation: first for build-plan discovery, then for the resolved build-on/build-for architectures (craft-application#150, f51c0e3b).
stealth/space-bunny-alpha — closed resolved Merged into main as f51c0e3b via #150, adding dual grammar evaluation to derive the build plan and resolve build-on/build-for architectures transparently.
stealth/space-bunny-alpha — closed resolved Merged in canonical/craft-application#150 (f51c0e3b), adding two-pass grammar evaluation to obtain the build plan and resolve target build-on/build-for architectures.
qwen/qwen3.6-35b-a3b — — Merged after approval and passing CI. Implements dual grammar evaluation to transparently resolve build plans and target architectures. Minor coverage gaps were noted but did not block the merge.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#279 feat: always process the project's grammar craft-application merged Merged PR #279 (commit 3432cf7d), which always processes grammar and selects the first build-plan architecture or the host architecture when build-for is unspecified.
76%