← Back to issue list

feat: evaluate project using grammar rules

View original Github issue

Metadata

Project
craft-application
Number
#150
Type
pull request
State
merged
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Merged after approval and passing CI. Implements dual grammar evaluation to transparently resolve build plans and target architectures. Minor coverage gaps were noted but did not block the merge.

Suggested action:

No scores available.

Issue body

Grammar evaluation is done for a specific set of build-on/build-for architectures, however those are listed in the build plan which in turn is obtained from the project model. To keep the grammar handling transparent to the application we evaluate grammar twice, first to obtain the build plan, and then to resolve for the correct set of architectures. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? ----- (CRAFT-2322)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after approval and passing CI. Implements dual grammar evaluation to transparently resolve build plans and target architectures. Minor coverage gaps were noted but did not block the merge.
qwen3.6-35b-a3b-mtp-q6 Implemented dual grammar evaluation to transparently resolve build architectures and generate build plans. Approved by @lengau for Charmcraft compatibility and successfully merged.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#279 feat: always process the project's grammar craft-application merged Merged a fix for destructive-mode clean failures when no target arch is specified. Implements fallback logic to always process project grammar using the provided arch, first plan item, or host arch. Approved and passed CI.
78%
#138 feat: allow the app to select the grammar variant craft-grammar merged Merged implementation allowing the app to select grammar variants. Resolves #126 and CRAFT-4745. Approved by two reviewers, passed all CI checks, and modified four files with a net addition of 46 lines.
72%
#203 feat: support 'for' statements imagecraft merged Merged after adding 'for' statement support to the advanced grammar. Approved by two reviewers, passed all CI checks, and resolves #201. Changes affect 10 files.
70%