← Back to issue list

fix: quote field names in error messages

View original Github issue

Metadata

Project
craft-application
Number
#157
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged a fix that quotes field names in error messages to improve tracking. Approved by two reviewers, passed CI, and maintained 100% test coverage on modified lines across two files.

Suggested action:

No scores available.

Issue body

I'm unclear whether this would be considered a 'breaking change' since we do have several app-level tests that would need changing. I'm guessing not? - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? ----- This makes tracking the field names easier. See: https://github.com/canonical/rockcraft/pull/440/files#r1417818696

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix that quotes field names in error messages to improve tracking. Approved by two reviewers, passed CI, and maintained 100% test coverage on modified lines across two files.
qwen3.6-35b-a3b-mtp-q6 Merged a fix to quote field names in error messages, improving debuggability. The change passed all tests, maintained 99.18% code coverage, and was approved without breaking changes.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#329 style: fix typo in error message craft-application merged Merged a single-line change correcting a typo in an error message. Approved by two reviewers and passed CI checks before integration.
74%
#270 fix: correctly print multi-line errors craft-cli merged Merged fix for multi-line error printing. The change splits error strings to print each line individually, preventing leftover characters from previous progress messages. Approved by two reviewers, passed CI, and resolves #263.
73%
#1200 fix: indent multiline examples correctly craft-parts merged Merged a fix that correctly indents multiline examples. Approved by two reviewers and passed CI checks. Modified one file with 34 additions and 18 deletions.
71%