← Back to issue list

fix: use platformdirs replace pyxdg for cache path

View original Github issue

Metadata

Project
craft-application
Number
#169
Type
pull request
State
merged
Author
syu-w
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #169 (commit 6e66bbed, Jan 2024) swapped pyxdg for platformdirs to resolve the cache-directory creation race, closing #167. Application.cache_dir now returns a pathlib.Path via user_cache_path(..., ensure_exists=True).

Resolution: closed resolved

Reason: The PR was approved and merged as commit 6e66bbed ('fix: use platformdirs replace pyxdg for cache path (#169)'), which states 'Fixes: #167' and closed issue #167. craft_application/application.py now uses platformdirs.user_cache_path(..., ensure_exists=True), adding platformdirs>=3.10 as a dependency in pyproject.toml.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Solve a race condition issue when creating dir under pyxdg. Notice that `cache_dir` is now return `Path` not `str`. Fixes: #167

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #169 (commit 6e66bbed, Jan 2024) swapped pyxdg for platformdirs to resolve the cache-directory creation race, closing #167. Application.cache_dir now returns a pathlib.Path via user_cache_path(..., ensure_exists=True).
stealth/space-bunny-alpha — closed resolved Merged PR #169 replaced pyxdg with platformdirs for cache paths, fixing #167’s directory-creation race; cache_dir now returns Path. Resolving commit: 6e66bded.
qwen/qwen3.6-35b-a3b — — Merged. Replaced pyxdg with platformdirs for cache paths, fixing a directory creation race condition. Updated cache_dir to return Path. Approved by two reviewers, passed CI, and maintains 99.2% coverage. Fixes #167.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/craft-application#167 (confidence 97%)

    Issue #167 'Cache directories that already exist get an error' was closed by this PR, which fixed the pyxdg mkdir race; its title/description confirm the link.

Related issues

Issue Project State Summary Similarity
#167 Cache directories that already exist get an error craft-application closed Fixed existing-cache crashes by replacing pyxdg with platformdirs in merged PR #169 (commit 6e66bbed).
78%