← Back to issue list

feat: launchpad client

View original Github issue

Metadata

Project
craft-application
Number
#194
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #194 (commit 1e105e49) added craft_application/launchpad, a generic launchpadlib wrapper with a unified interface, modelled on Snapcraft's remote-build client. It later gained models, getters and bug fixes (#215-#615).

Resolution: closed resolved

Reason: PR #194 was approved by 2 reviewers and merged into main as commit 1e105e49 ('feat: launchpad client'), adding craft_application/launchpad/{launchpad.py,errors.py,models/}. The package remains in HEAD and is consumed by craft_application/commands/remote.py, with subsequent follow-ups (#215, #230, #235) building on it.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This client is a wrapper around launchpadlib that provides a unified interface. It's heavily inspired by the Launchpad wrapper used in snapcraft's most recent remote build, but with tweaks to make it more generic. - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #194 (commit 1e105e49) added craft_application/launchpad, a generic launchpadlib wrapper with a unified interface, modelled on Snapcraft's remote-build client. It later gained models, getters and bug fixes (#215-#615).
stealth/space-bunny-alpha — closed resolved Merged PR #194 added a generic Launchpad client wrapping launchpadlib, providing a unified interface inspired by Snapcraft’s remote-build client.
qwen/qwen3.6-35b-a3b — — Merged a generic Launchpad client wrapper around launchpadlib. Approved by two reviewers and passed CI. Adds 1632 lines across 20 files to provide a unified interface inspired by snapcraft's remote build implementation.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#215 feat: add getters to launchpad object craft-application merged Merged PR #215 added typed getters for Launchpad resources, including recipe, project, and repository access, via commit a4ec37ba.
72%
#4389 feat(remote-build): add LaunchpadClient snapcraft closed Closed unmerged and superseded by #4390, which merged the LaunchpadClient and WorkTree migration as commit 80ffb5191.
71%
#4708 feat(remote): get a user-provided Launchpad project snapcraft merged Merged PR #4708 in commit 6ff73a1fc, adding retrieval of a user-provided Launchpad project for Snapcraft remote builds.
70%