← Back to issue list

feat!: use the build plan on LifecycleService

View original Github issue

Metadata

Project
craft-application
Number
#216
Type
pull request
State
merged
Author
tigarmo
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #216 as commit ae145304 (merge commit c5218f08), updating LifecycleService to use the build plan and reject destructive runs with zero or multiple items.

Resolution: —

Evaluated by: mr-cal-bot

No scores available.

Issue body

This commit updates the LifecycleService to make use of the project's build plan when running. This specially affects destructive mode, where: - Trying to run a build plan with no items is a (new) error; - Trying to run a build plan with multiple items is a (new) error; Note that although some forms of the "clean" command are also performed destructively, in this case we don't use the build plan. The rationale for this is: - The lifecycle's local clean is always the same, regardless of target arch; - Trying to define a build plan item via e.g. "appname clean --build-for=x" looks non-sensical (why define a "build-for" if I want to "clean"), and from a user's perspective calling "appname clean --destructive-mode" should just cleanup whatever was built previously. - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — — Merged PR #216 as commit ae145304 (merge commit c5218f08), updating LifecycleService to use the build plan and reject destructive runs with zero or multiple items.
stealth/space-bunny-alpha — closed resolved Merged PR #216 at ae145304, making LifecycleService use the build plan and rejecting destructive runs with zero or multiple plan items.
qwen/qwen3.6-35b-a3b — — Merged after review. Updates LifecycleService to use the project build plan during execution, adding validation for empty or multiple items in destructive mode. Filtering BuildInfo by matching host base was deferred to a follow-up task.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.