← Back to issue list

fix(launchpad): correct the uploading build state

View original Github issue

Metadata

Project
craft-application
Number
#236
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged a fix correcting an incorrect string in the buildstate property for Launchpad builds. The change was approved by reviewers, passed CI checks, and required only a single line modification.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? ----- I used the wrong string. Strings are visible in the `buildstate` property of builds: * https://api.launchpad.net/devel.html#charm_recipe_build * https://api.launchpad.net/devel.html#snap_build

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix correcting an incorrect string in the buildstate property for Launchpad builds. The change was approved by reviewers, passed CI checks, and required only a single line modification.
qwen3.6-35b-a3b-mtp-q6 Merged a fix correcting an invalid string used for the Launchpad API buildstate property in charm and snap builds. The change passed tox checks and was successfully integrated by maintainer lengau.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#219 fix: add launchpad build types and states craft-application merged Merged a maintainer fix adding launchpad build types and states. The two-line change in one file passed CI and received approval from two reviewers before integration.
82%
#230 fix: make launchpad client always create relevant files craft-application merged Merged a fix ensuring the launchpad client always creates relevant files. Approved by two reviewers with passing CI checks. The change adds 138 lines across three files.
76%
#244 fix: handle multiple types of Launchpad error when getting projects craft-application merged Merged a fix that handles multiple types of Launchpad errors when retrieving projects. Approved by two reviewers, passed CI checks, and applied minimal changes (+2/-2 lines in one file.)
75%
#224 fix(remotebuild): create the launchpad instance correctly craft-application merged Approved by two reviewers and passing CI, the fix to correctly create the remotebuild launchpad instance was successfully merged.
74%
#78 fix(ci): force push to the correct launchpad repo fetch-service merged Merged a one-line CI fix correcting a force push to the proper Launchpad repository. Approved by two reviewers with zero unresolved comments and no failing checks.
74%
#532 update requirements-focal.txt to use the launchpad charmcraft merged Merged after approval, updating requirements-focal.txt to use the launchpad. The change involved a single line modification with no review comments or CI checks required.
73%
#221 fix: separate the builds for Launchpad recipe types craft-application merged Successfully merged after approval from two reviewers and passing CI checks. The maintainer's changes (+36/-16 lines) separated builds for Launchpad recipe types, resolving the configuration issue.
72%
#384 fix(remotebuild): push git tags to launchpad craft-application merged Merged a fix that pushes git tags to Launchpad, enabling applications to derive versions from tags. Approved by two reviewers, passed CI checks, and applied with minimal changes across two files.
71%
#573 ci: fix bugs in Launchpad sync fetch-service merged Merged a fix for the Launchpad sync workflow resolving broken tag pushes and a hardcoded username. Approved by two reviewers, passed all CI checks, and modified one file (+2/-3 lines).
70%