fix(launchpad): correct the uploading build state
Metadata
Current evaluation
Merged PR #236 corrected the Launchpad uploading build-state string to match the API's buildstate values.
Resolution: closed resolved
Reason: PR #236 was approved and merged as commit d4c282fe, fixing the incorrect uploading state string.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox`?
-----
I used the wrong string. Strings are visible in the `buildstate` property of builds:
* https://api.launchpad.net/devel.html#charm_recipe_build
* https://api.launchpad.net/devel.html#snap_build
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #236 corrected the Launchpad uploading build-state string to match the API's buildstate values. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #236 corrected the wrong string used for Launchpad builds’ uploading build state, changing one line to match Launchpad’s buildstate values. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix correcting an incorrect string in the buildstate property for Launchpad builds. The change was approved by reviewers, passed CI checks, and required only a single line modification. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #219 fix: add launchpad build types and states | craft-application | merged | Merged PR #219 via commit 3cf3b874, adding Launchpad build types and states in a two-line change. | |
| #224 fix(remotebuild): create the launchpad instance correctly | craft-application | merged | Merged PR #224 as commit 87bc56a7, fixing remotebuild to create the Launchpad instance correctly. | |
| #230 fix: make launchpad client always create relevant files | craft-application | merged | Merged PR #230 fixed Launchpad client file creation and landed as commit ff1714d4. |