← Back to issue list

YAML loading either needs simplification or better testing

View original Github issue

Metadata

Project
craft-application
Number
#24
Type
issue
State
open
Author
lengau
Labels
—
Created
Updated
Closed
—

Current evaluation

YAML loader exception handling from PR #20 may be redundant with current PyYAML; no regression test exercises it, and the open issue lacks a concrete reproducer.

Suggested action: needs triage

Reason: The maintainer identifies a specific except clause in PR #20 but explicitly remains unsure whether current PyYAML still requires it and notes that the existing failure never reaches the dict constructor. The issue has no labels, maintainer response, or concrete fixture; its only comment is an automated Jira notification, so the loader behavior must first be reproduced and the clause verified or removed.

Evaluated by: mr-cal-bot

Impact: 30 Quick Win: 10 Complexity: 42 Confidence: 84 Actionability: 60

Issue body

See [this comment thread](https://github.com/canonical/craft-application/pull/20/files/88c186c8a772c0ad8f5a8cfeb8fe84d352729111#diff-e1faa3a7dda894734ce22e2d235c8e3a1fd7e0ad2ae234fff07ed0fe131af6d3). The modifications made to the YAML loader may be more than is needed with the latest pyyaml, but I'm not confident enough to say so. If the questioned `except` clause is needed, we should have a test for it that has it raise that error, as right now the loader fails with the same issue before it gets to the dict constructor.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 30
Quick Win: 10
Complexity: 42
Confidence: 84
Actionability: 60
needs triage YAML loader exception handling from PR #20 may be redundant with current PyYAML; no regression test exercises it, and the open issue lacks a concrete reproducer.
qwen/qwen3.6-35b-a3b
Impact: 30
Quick Win: 14
Complexity: 20
Confidence: 60
Actionability: 60
needs triage Maintainer self-filed task to investigate whether a TypeError handler in the YAML loader is needed; no maintainer triage since 2024-03.
qwen/qwen3.8-27b
Impact: 30
Quick Win: 18
Staleness: 75
Complexity: 40
Confidence: 55
Support Request: 0
needs triage Maintainer self-filed task to simplify or add tests for the YAML loader's questioned except clause; no maintainer triage, labels, or follow-up since 2024-03.
qwen/qwen3.6-35b-a3b
Staleness: 85
Complexity: 40
Confidence: 75
Support Request: 10
needs triage Issue discusses YAML loader modifications and testing needs. Created 1139 days ago, last activity 424 days ago. No maintainer response, unlabelled, requires triage to assess relevance and action.
qwen3.6-35b-a3b-mtp-q6
Staleness: 95
Complexity: 15
Confidence: 85
Support Request: 5
close stale Open issue regarding YAML loader modifications and missing test coverage for exception handling. Lacks maintainer labels, assignee, and has seen no activity in over a year.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-application#20 (confidence 100%)

    The issue explicitly links to the YAML-loader discussion in this merged PR; commit 1382ca87 added the referenced project model.

Related issues

No related issues found above the similarity threshold.