← Back to issue list

YAML loading either needs simplification or better testing

View original Github issue

Metadata

Project
craft-application
Number
#24
Type
issue
State
open
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Maintainer self-filed task to simplify or add tests for the YAML loader's questioned except clause; no maintainer triage, labels, or follow-up since 2024-03.

Suggested action: needs triage

Reason: The issue was filed by maintainer lengau referencing a PR #20 comment thread, asking whether the YAML loader's except clause is still needed with newer pyyaml and requesting a test if it is. No labels, assignee, or maintainer response exist beyond the Jira sync bot comment, and the last activity was 465 days ago. It is a valid internal cleanup/testing task that needs triage to determine whether the code has since changed.

Impact: 30 Quick Win: 18.0 Staleness: 75 Complexity: 40 Confidence: 55 Support Request: 0

Issue body

See [this comment thread](https://github.com/canonical/craft-application/pull/20/files/88c186c8a772c0ad8f5a8cfeb8fe84d352729111#diff-e1faa3a7dda894734ce22e2d235c8e3a1fd7e0ad2ae234fff07ed0fe131af6d3). The modifications made to the YAML loader may be more than is needed with the latest pyyaml, but I'm not confident enough to say so. If the questioned `except` clause is needed, we should have a test for it that has it raise that error, as right now the loader fails with the same issue before it gets to the dict constructor.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 30
Quick Win: 18.0
Staleness: 75
Complexity: 40
Confidence: 55
Support Request: 0
needs triage Maintainer self-filed task to simplify or add tests for the YAML loader's questioned except clause; no maintainer triage, labels, or follow-up since 2024-03.
qwen/qwen3.6-35b-a3b
Staleness: 85
Complexity: 40
Confidence: 75
Support Request: 10
needs triage Issue discusses YAML loader modifications and testing needs. Created 1139 days ago, last activity 424 days ago. No maintainer response, unlabelled, requires triage to assess relevance and action.
qwen3.6-35b-a3b-mtp-q6
Staleness: 95
Complexity: 15
Confidence: 85
Support Request: 5
close stale Open issue regarding YAML loader modifications and missing test coverage for exception handling. Lacks maintainer labels, assignee, and has seen no activity in over a year.
qwen3.6-35b-a3b-mtp-q6
Staleness: 92
Complexity: 40
Confidence: 80
Support Request: 10
close stale YAML loader modifications require verification against current pyyaml. The exception handling lacks a test, causing premature failures. Open and awaiting review to simplify the code or add proper test coverage.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.