← Back to issue list

feat(application)!: make configure_services not take parameters

View original Github issue

Metadata

Project
craft-application
Number
#259
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged in commit 7e3f0f3e, removing build_for and platform from Application._configure_services() so services consume the build plan instead.

Resolution: closed resolved

Reason: PR canonical/craft-application#259 was approved and merged as commit 7e3f0f3e, completing the breaking API change.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Removes `build_for` and `platform` from `Application._configure_services()` This will break any application that implements _configure_services and any service that expects these. The new methodology is to pass the build plan to a service and use that. - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in commit 7e3f0f3e, removing build_for and platform from Application._configure_services() so services consume the build plan instead.
stealth/space-bunny-alpha — closed resolved Merged breaking change (canonical/craft-application#259, commit 7e3f0f3e) dropping build_for and platform params from Application._configure_services(); callers now pass the build plan to services instead. Approved by 3 reviewers.
stealth/space-bunny-alpha — closed resolved Merged in canonical/craft-application#259 (7e3f0f3e), removing build_for and platform from Application._configure_services() in favor of passing the build plan to services.
qwen/qwen3.6-35b-a3b — — Merged a breaking change removing build_for and platform from Application._configure_services(). Services now receive the build plan directly. Approved by three reviewers and passed CI.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.