← Back to issue list

build(deps): update pyright

View original Github issue

Metadata

Project
craft-application
Number
#266
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Pyright dependency bump by lengau approved by 3 reviewers and merged into main as commit d2729013, changing pyright pins in two files (+3/-3 lines).

Resolution: closed resolved

Reason: The PR itself was the resolution: canonical/craft-application#266 ("build(deps): update pyright") was merged into main, recorded in git history as commit d2729013 "build(deps): update pyright (#266)" with review status approved and zero unresolved comments.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Pyright dependency bump by lengau approved by 3 reviewers and merged into main as commit d2729013, changing pyright pins in two files (+3/-3 lines).
stealth/space-bunny-alpha — closed resolved Pyright dependency bump merged via commit d2729013 after 3 approvals; the 2-file, +3/-3 pin update was a routine Renovate-style change. Pyright was later dropped in #327 and replaced by ty in #1084.
stealth/space-bunny-alpha — closed resolved Merged the Pyright dependency update in canonical/craft-application#266 as commit d2729013 after three reviewer approvals.
qwen/qwen3.6-35b-a3b — — Merged the pyright dependency update following three reviewer approvals and passing CI checks. The minimal changes affected two files.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-application#327 (confidence 72%)

    Later commit 4c45c0ed "build(deps): remove pyright (#327)" dropped pyright from the project entirely, following this series of bumps.

  • Superseded By: canonical/craft-application#1084 (confidence 60%)

    Commit 345bd5d9 later replaced mypy and pyright with ty in the typing toolchain, obsoleting these pyright bumps.

  • Related To: canonical/craft-application#170 (confidence 55%)

    Same maintainer's earlier pyright bump (commit 20eb1296), part of the recurring dependency-update chain.

Related issues

Issue Project State Summary Similarity
#4 build(deps): update dependency pyright to v1.1.390 craft-artifacts merged Renovate bump of pyright 1.1.389 -> 1.1.390 approved and merged into main via merge commit 1d553b3 (squashed commit ca8814a), updating the pinned pyright version in 2 files.
85%
#290 build(deps): update dependency pyright to v1.1.390 starbase merged Renovate dependency bump of pyright 1.1.389 -> 1.1.390, approved and merged into main as commit ca8814a (+8/-8 lines in 2 files).
85%
#701 build(deps): update pyright to 1.1.358 craft-parts merged Merged the Pyright 1.1.358 dependency update in #701 as commit 9a30c724; follow-up lint issues were fixed by #702.
84%
#181 build(deps): update dependency pyright to v1.1.403 (main) craft-archives merged Renovate PR merged into main as commit d9c6967, bumping pyright from ==1.1.390 to ==1.1.403 (2 files, +5/-5). All 18 CI checks passed, approved by 2 reviewers; a later PR (#209) took it to 1.1.406.
84%
#243 build(deps): update dependency pyright to v1.1.379 starbase merged Renovate dependency bump of pyright 1.1.378 -> 1.1.379 approved and merged into main in commit 38e8a72, a one-line pin change in common.mk.
83%
#59 build(deps): update dependency pyright to v1.1.384 craft-grammar merged Renovate's pyright bump 1.1.383 -> 1.1.384 was approved and merged into main via commit 6c95e6b (single-line pin change); later superseded by bumps in #61, #64, #66, #68 and eventually pyright's removal.
83%
#122 build(deps): update dependency pyright to v1.1.398 imagecraft merged Renovate's automated pyright bump 1.1.396 -> 1.1.398 was approved (2 reviewers) and merged into main via PR #122, changing the pinned version in 2 files (+5/-5).
83%
#632 build(deps): update dependency pyright to v1.1.377 craft-providers merged Renovate PR bumping the pyright pin from 1.1.376 to 1.1.377 was approved and merged into main (commit 87354aa), a one-line dependency change.
83%
#311 build(deps): update dependency pyright to v1.1.391 starbase merged Renovate bumped pyright 1.1.390 to 1.1.391 in 2 files; approved and merged to main as commit 4270834. Pyright was later removed from build deps in #327 (4c45c0e).
82%
#209 build(deps): update dependency pyright to v1.1.406 (main) craft-archives merged Renovate dependency bump of pyright from 1.1.403 to 1.1.406 approved and merged into main via PR #209 (commit ffd2ded). All CI checks passed; pyright was later removed entirely in #253.
82%