← Back to issue list

Craft-application reading craft-archives version

View original Github issue

Metadata

Project
craft-application
Number
#271
Type
issue
State
closed
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Fixed: the __version__ fallback in craft_application/__init__.py queried importlib.metadata for the wrong package ("craft-archives"). Merged PR #288, commit 7e7171bc, changed it to "craft-application".

Resolution: closed resolved

Reason: Maintainer-reported copy/paste bug resolved by commit 7e7171bc ("fix: use correct package for version", PR #288), which replaced version("craft-archives") with version("craft-application") in the _version ImportError fallback. A pickaxe search confirms that commit removed the craft-archives lookup, and current HEAD now calls version("craft-application").

Evaluated by: mr-cal-bot

No scores available.

Issue body

### Bug Description If `._version` not set, craft-application reads version from craft-archives. ```python try: from ._version import __version__ except ImportError: # pragma: no cover from importlib.metadata import version, PackageNotFoundError try: __version__ = version("craft-archives") except PackageNotFoundError: __version__ = "dev" ``` ### To Reproduce This can be verified by simple inspection of `craft_application/__init__.py`. ### part yaml ```shell N/A ``` ### Relevant log output ```shell N/A ```

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Fixed: the __version__ fallback in craft_application/__init__.py queried importlib.metadata for the wrong package ("craft-archives"). Merged PR #288, commit 7e7171bc, changed it to "craft-application".
stealth/space-bunny-alpha — closed resolved Merged PR #288 (commit 7e7171bc) fixed the fallback version lookup, changing it from craft-archives to craft-application.
qwen/qwen3.6-35b-a3b — — Closed without resolution or fix. The report highlighted a version fallback bug but received no developer response beyond a Jira sync notification. The issue appears abandoned due to prolonged inactivity.
qwen/qwen3.6-35b-a3b — — A version fallback bug in craft-application was reported but closed without resolution or a fix. No discussion or patch was provided, indicating the report was abandoned.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/craft-application#288 (confidence 95%)

    Merged PR titled 'fix: use correct package for version', commit 7e7171bc; the only change to craft_application/__init__.py addressing this lookup.

Related issues

Issue Project State Summary Similarity
#288 fix: use correct package for version craft-application merged Merged PR #288 corrected the package queried for craft-application's version in a one-line change (commit 7e7171bc).
74%
#4614 feat(craft-application): migrate version command snapcraft merged Merged PR #4614 (commit 885106d06) migrated Snapcraft's version command to craft-application, resolving #4468; legacy version handling remained out of scope.
71%
#4277 requirements: bump craft-archives snapcraft merged Merged PR #4277 (commit 7e6e3173, 2023-07-13) bumped craft-archives from 1.1.1 to 1.1.2, restoring support for local package repositories using url: file:///... (craft-archives PR #93).
70%