← Back to issue list

Fix & re-enable test checking for snaps

View original Github issue

Metadata

Project
craft-application
Number
#306
Type
issue
State
open
Author
lengau
Labels
—
Created
Updated
Closed
—

Current evaluation

Re-enable and fix the commented-out test_get_basic_items integration test (tests/integration/launchpad/test_anonymous_access.py), disabled in PR #307 after lengau's private snap broke it; still commented out with a TODO linking this issue.

Suggested action: needs triage

Reason: The issue is unlabelled and has no human maintainer response — the only comment is the syncronize-issues-to-jira bot announcing CRAFT-2780, so it has never been assessed or prioritized. It is confirmed still open: tests/integration/launchpad/test_anonymous_access.py lines 51-60 remain fully commented out with "# TODO: Re-enable this / https://github.com/canonical/craft-application/issues/306", so it is not close_resolved. Impact is test-only (no library behaviour change requested, though the disabled test may be masking how SnapRecipe.find handles private snaps owned by the author), and the fix requires live Launchpad access to determine whether the brittleness is in the test (depends on personal account 'lengau', plus a missing `models` import that would NameError on re-enable) or in the library, which is why it needs triage rather than keep_open.

Evaluated by: mr-cal-bot

Impact: 22 Quick Win: 7 Complexity: 38 Confidence: 74 Actionability: 52

Issue body

### What needs to get done Re-enable the `test_get_basic_items` test after fixing it. ### Why it needs to get done This test broke unexpectedly after I added a private snap for myself.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha
Impact: 22
Quick Win: 7
Complexity: 38
Confidence: 74
Actionability: 52
needs triage Re-enable and fix the commented-out test_get_basic_items integration test (tests/integration/launchpad/test_anonymous_access.py), disabled in PR #307 after lengau's private snap broke it; still commented out with a TODO linking this issue.
qwen/qwen3.6-35b-a3b
Impact: 30
Quick Win: 19
Complexity: 20
Confidence: 70
Actionability: 80
keep open Re-enable and fix the disabled test_get_basic_items test in tests/integration/launchpad/test_anonymous_access.py, which was commented out after the author's private snap made it fail.
qwen/qwen3.8-27b
Impact: 15
Quick Win: 11
Staleness: 75
Complexity: 25
Confidence: 80
Support Request: 0
keep open Maintainer task to fix and re-enable the commented-out test_get_basic_items integration test in tests/integration/launchpad/test_anonymous_access.py, which broke when the author added a private snap. Still commented out at HEAD with a TODO referencing this issue; dormant since April 2024.
qwen/qwen3.6-35b-a3b
Staleness: 85
Complexity: 15
Confidence: 75
Support Request: 0
close stale Unlabelled maintainer task to fix and re-enable a broken snap-related test. Inactive for over 14 months with only an automated Jira sync comment.
qwen3.6-35b-a3b-mtp-q6
Staleness: 95
Complexity: 20
Confidence: 85
Support Request: 0
close stale Request to fix and re-enable a broken snap check test. Open for over two years with only an automated Jira sync comment and no maintainer engagement or progress.

Update history

No update history recorded yet.

Related work

  • Caused By: canonical/craft-application#307 (confidence 88%)

    Commit be9bf8e5 'tests: disable broken integration test (#307)' is the change that commented out test_get_basic_items; issue #306 is the follow-up tracking the fix and re-enable.

Related issues

Issue Project State Summary Similarity
#307 tests: disable broken integration test craft-application merged Merged in #307 (be9bf8e5), temporarily disabling the broken test_get_basic_items Launchpad integration test to restore CI; permanent repair remains tracked in #306.
72%
#1542 tests: add integration tests for build snaps snapcraft merged PR #1542 merged as 8c9900f38, adding integration coverage for build snaps; two scenarios remained excluded due to Launchpad bugs #1716054 and #1716055.
71%