← Back to issue list

revert: abstract Project class and `_providers_base()`

View original Github issue

Metadata

Project
craft-application
Number
#322
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged #322 (commit e893f1da): partial revert of aeae554/#302, adding a default name@channel Project._providers_base() while keeping devel-base validation. CRAFT-2824.

Resolution: closed resolved

Reason: PR #322 was merged as commit e893f1da ('revert: abstract Project class and `_providers_base()` (#322)'), landing a default name@channel _providers_base() on the Project model so apps no longer subclass it; the follow-up default BuildPlanner landed in #326 (4833c0e9, craft-application 3.0.0).

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? ----- This is a partial revert of 'aeae554 feat!: validate devel bases (#302)'. The base validation from #302 has not been reverted, but there is now a default implementation for `Project._providers_base()` such that applications do not need to subclass the Project model. The default naming convention for bases is `name@channel`. Examples: - `ubuntu@24.04` - `ubuntu@devel` - `almalinux@9` Charmcraft is the only public application that can use this default `_providers_base()`. A default BuildPlanner will come in a subsequent PR. (CRAFT-2824)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #322 (commit e893f1da): partial revert of aeae554/#302, adding a default name@channel Project._providers_base() while keeping devel-base validation. CRAFT-2824.
stealth/space-bunny-alpha — closed resolved Merged #322 (e893f1da): partially reverted aeae554/#302, adding a default name@channel _providers_base() while retaining devel-base validation.
stealth/space-bunny-alpha — closed resolved Merged PR #322 as e893f1da, partially reverting aeae554: base validation remains, while a default Project._providers_base() removes the need to subclass Project.
qwen/qwen3.6-35b-a3b — — Merged partial revert of aeae554, dropping Project class abstraction and _providers_base(). Introduces a default _providers_base() to eliminate mandatory subclassing while retaining base validation. Approved by two reviewers and passed CI.

Update history

No update history recorded yet.

Related work

Related issues

No related issues found above the similarity threshold.