fix: apply yaml transforms first
Metadata
Current evaluation
Merged in canonical/craft-application#334 (commit feb8072b), applying YAML transforms before project-variable expansion; adopted by snapcraft#4779 via craft-application 2.6.3.
Resolution: closed resolved
Reason: PR #334 was approved and merged as commit feb8072b, fixing transform ordering so extension-added variables are available during evaluation. Snapcraft#4779 adopted the fix by upgrading to craft-application 2.6.3 and added regression coverage, resolving snapcraft#4771.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox`?
-----
As raised in Matrix ([source](https://matrix.to/#/!GGqzbFAUQprdPgYYCM:ubuntu.com/$5CJQkAjgqbNn48zcF06HS8a0_0cjfogVCA_BDFi7XZE?via=ubuntu.com&via=matrix.org&via=kde.org)), `_extra_yaml_transforms` needs to occur before evaluating project variables.
For example, snapcraft will expand extensions in `_extra_yaml_transforms` and some extensions add project variables to the yaml.
Fixes https://github.com/canonical/snapcraft/issues/4771
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/craft-application#334 (commit feb8072b), applying YAML transforms before project-variable expansion; adopted by snapcraft#4779 via craft-application 2.6.3. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged craft-application#334 to run YAML transforms before project-variable evaluation. Snapcraft#4779 adopted the fix via craft-application 2.6.3, closing snapcraft#4771. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix ensuring _extra_yaml_transforms execute before project variable evaluation. Resolves snapcraft#4771 by allowing extensions that inject project variables to function correctly. Approved by two reviewers and passed CI checks. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/snapcraft#4779
(confidence 99%)
Merged dependency update to craft-application 2.6.3, consuming the fix and adding BUILD_ON regression coverage.
-
Related To:
canonical/snapcraft#4771
(confidence 99%)
Original Snapcraft bug affected by extension-added project variables and resolved through this change.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #5499 fix: evaluate variables in project file | snapcraft | merged | Merged in canonical/snapcraft#5499 (commit abd5db829), restoring project-variable expansion and fixing #5491 in Snapcraft 8.9.2. |