← Back to issue list

fix(PackCommand): remove 'parts' argument

View original Github issue

Metadata

Project
craft-application
Number
#341
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged the fix to remove the 'parts' argument from PackCommand. Simplified after PR #340, the change passed CI, received two approvals, and was successfully integrated into the main branch.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? ----- This ended up being extremely simple after landing #340. Tested via https://github.com/canonical/snapcraft/pull/4797

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged the fix to remove the 'parts' argument from PackCommand. Simplified after PR #340, the change passed CI, received two approvals, and was successfully integrated into the main branch.
qwen3.6-35b-a3b-mtp-q6 Merged a fix removing the 'parts' argument from PackCommand. The update was simplified after PR #340 landed and passed testing before integration.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4797 refactor: change PackCommand parent snapcraft merged Merged a refactor updating the PackCommand parent class to eliminate duplicated code via upstream simplifications. Approved by two reviewers, passed CI, and reduced the codebase by 23 lines across one file.
75%
#1565 cli: add the pack command snapcraft merged Merged the pack CLI command, replacing the previous assemble implementation. Approved by one reviewer, passed CI checks, and updated seven files with 164 additions and 16 deletions.
71%