← Back to issue list

fix: craft-cli branch ref to main (rockcraft branch merged)

View original Github issue

Metadata

Project
craft-application
Number
#369
Type
pull request
State
closed
Author
yanksyoon
Labels
—
Created
Updated
Closed

Current evaluation

PR closed unmerged by author yanksyoon; the craft-cli branch-ref fix was relocated to canonical/rockcraft#622, and the underlying build failure (rockcraft#621) was finally fixed by merged rockcraft#624 (commit 849cbc30).

Resolution: closed superseded

Reason: The author closed the PR on 2024-07-03 stating 'This is being worked on: canonical/rockcraft#622', and rockcraft#622 was likewise closed unmerged after proper craft-* library releases replaced the rockcraft-branch ref; rockcraft#624 (commit 849cbc30) resolved the original issue #621.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? ----- Rockcraft branch in craft-cli got merged. This causes builds to fail. https://github.com/canonical/rockcraft/issues/621

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR closed unmerged by author yanksyoon; the craft-cli branch-ref fix was relocated to canonical/rockcraft#622, and the underlying build failure (rockcraft#621) was finally fixed by merged rockcraft#624 (commit 849cbc30).
stealth/space-bunny-alpha — closed superseded Closed unmerged as duplicate work; the author moved the craft-cli branch-reference fix to canonical/rockcraft#622.
stealth/space-bunny-alpha — closed superseded Closed unmerged because the same craft-cli branch-reference fix was being handled in canonical/rockcraft#622, as noted by the author.
qwen/qwen3.6-35b-a3b — — Closed without merging. The author indicated the branch reference fix is being handled in a separate pull request and closed this PR to avoid duplication.

Update history

No update history recorded yet.

Related work

  • Superseded By: rockcraft#622 (confidence 95%)

    Author closed this PR saying the fix was being continued in canonical/rockcraft#622 'fix: craft-cli branch ref to main'.

  • Duplicate Of: rockcraft#622 (confidence 90%)

    Same title and change (craft-cli branch ref to main) re-targeted in the rockcraft repo where the branch pin lived.

  • Related To: rockcraft#621 (confidence 85%)

    Underlying bug report 'Recent merge in craft-cli causes rockcraft build to fail' that this PR intended to fix.

  • Likely Fixed By: rockcraft#624 (confidence 80%)

    Merged rockcraft#624 (commit 849cbc30) restored released-version constraints for craft-* libs, fixing #621 without needing this branch ref.

Related issues

Issue Project State Summary Similarity
#621 Recent merge in craft-cli causes rockcraft build to fail rockcraft closed Merged rockcraft#624 (commit 849cbc30) replaced the missing craft-cli rockcraft-branch requirement with released-version constraints, fixing the build failure.
81%
#622 fix: craft-cli branch ref to main rockcraft closed Closed unmerged after canonical/craft-application#369 and proper tool releases addressed the branch-ref conflict; maintainers recommended a release tag such as 1.4.0.
79%
#372 Merge `rockcraft` craft-application merged PR #372 merged into the temporary 2.x branch, adding reviewed rockcraft work and commit ccfe498d's corrected craft-cli/craft-parts constraints for the planned 2.9.0 release.
77%
#258 Merge `rockcraft` back into `main` craft-cli merged Merged PR #258 restored the rockcraft branch to main and added the missing Craft CLI 2.6.0 changelog entries.
76%
#767 Merge `rockcraft` back to `main` craft-parts merged Merged PR #767 restored the rockcraft branch to main with reviewed 1.33.0 changelog entries; two reviewers approved it.
72%
#1210 fix(commands): reference rockcraft.yaml in extensions help rockcraft closed PR #1210 (fix expand-extensions help to say rockcraft.yaml instead of snapcraft.yaml) was closed unmerged by its author as a duplicate of canonical/rockcraft#1103, which is already approved and CI-passing.
72%
#590 Merge `rockcraft` back into `main` craft-providers merged Merged the rockcraft branch into main via #590 after individual review, adding 2.6.0 changelog entries across six files; approved by two reviewers.
71%
#1082 fix: reference slug path in for rockcraft.yaml #2 rockcraft merged Merged in canonical/rockcraft#1082 via commit cae91c7d, correcting the CLI’s rockcraft.yaml reference link to the documentation slug rockcraft-yaml.
70%