refactor: use exit code constants when possible
Metadata
Current evaluation
Merged as commit e8651e46: replaced hardcoded exit codes with os.EX_* constants across 4 files (+11/-10), a partial fix for issue #379, which remains open for remaining cases.
Resolution: closed resolved
Reason: The PR itself was merged by maintainer lengau with 2 approving reviewers, landing as commit e8651e46 "refactor: use exit code constants when possible (#387)". os.EX_* constants are still in use throughout the codebase (errors.py, services/project.py, services/testing.py, application.py), confirming the refactor shipped.
Evaluated by: mr-cal-bot
Issue body
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit e8651e46: replaced hardcoded exit codes with os.EX_* constants across 4 files (+11/-10), a partial fix for issue #379, which remains open for remaining cases. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as e8651e46, replacing hardcoded exit codes with os.EX_* constants where possible; this partially addressed craft-application#379. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #387 (e8651e46), replacing hardcoded exit codes with standard constants where possible; a partial fix for still-open #379. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged refactoring that replaces hardcoded exit codes with constants. Approved by two reviewers and passed CI. Modifies four files and partially resolves issue #379. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/craft-application#379
(confidence 95%)
PR body declares it a 'Partial fix for #379'; that issue is still open for 128+signal.SIGINT in application.py/util/logging.py, bare return_code = 1 in Parts/Provider errors, and CraftError's default retcode
Related issues
No related issues found above the similarity threshold.