← Back to issue list

refactor: use exit code constants when possible

View original Github issue

Metadata

Project
craft-application
Number
#387
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged refactoring that replaces hardcoded exit codes with constants. Approved by two reviewers and passed CI. Modifies four files and partially resolves issue #379.

Suggested action:

No scores available.

Issue body

Partial fix for #379 - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged refactoring that replaces hardcoded exit codes with constants. Approved by two reviewers and passed CI. Modifies four files and partially resolves issue #379.
qwen3.6-35b-a3b-mtp-q6 Merged a refactoring pull request replacing hardcoded exit codes with constants. This change partially resolves issue #379, improving code consistency and maintainability.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#496 refactor: Reduce cyclomatic complexity fetch-service merged Merged refactoring changes that reduced cyclomatic complexity by extracting logic into dedicated functions. Approved by two reviewers, passed CI checks, and modified four files (+248/-201 lines).
77%
#1491 errors: use function for exit code snapcraft merged Merged a maintainer change to the error API that replaces a static exit code with a function. Approved by two reviewers with zero unresolved comments. The update modified three files (+3/-5 lines) and was integrated successfully.
74%
#56 Issues/44 refactor rockcraft merged Merged two small refactorings approved by one reviewer with zero unresolved comments. CI checks passed. Changes modified two files, adding 28 and removing 25 lines.
73%
#459 refactor: consolidate duplicated code chunks fetch-service merged Merged after receiving approval from two reviewers and passing all continuous integration checks. The pull request consolidated duplicated code chunks as a refactor, successfully integrating the changes into the codebase.
70%
#1357 refactor: reorganise constants charmcraft merged Merged a refactor reorganizing constants for Charmcraft environment variables, project filenames, and output files/directories across 47 files. Changes include 471 additions and 443 deletions. Approved by four reviewers with no unresolved comments.
70%