← Back to issue list

feat(lifecycle): break out _get_build_for method

View original Github issue

Metadata

Project
craft-application
Number
#414
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #414 (commit 947e1b4b) extracted LifecycleService._get_build_for() out of _init_lifecycle_manager in craft-application, closing issue #394; added unit test test_get_build_for and a changelog entry.

Resolution: closed resolved

Reason: The PR was approved by 2 reviewers and merged as commit 947e1b4b on main, adding _get_build_for to craft_application/services/lifecycle.py with unit test tests/unit/services/test_lifecycle.py::test_get_build_for and a docs changelog entry. The linked issue #394 was closed by this merge.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Fixes #394 - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #414 (commit 947e1b4b) extracted LifecycleService._get_build_for() out of _init_lifecycle_manager in craft-application, closing issue #394; added unit test test_get_build_for and a changelog entry.
stealth/space-bunny-alpha — closed resolved Merged PR #414 (947e1b4b) extracted LifecycleService._get_build_for() from _init_lifecycle_manager, implementing craft-application#394.
qwen/qwen3.6-35b-a3b — — Merged a refactoring that extracts the _get_build_for method from the lifecycle module, resolving issue #394. Approved by two reviewers and passing CI, the change modifies three files with a net addition of 81 lines.

Update history

No update history recorded yet.

Related work

  • Related To: craft-application#394 (confidence 96%)

    Issue 'Implement _get_build_for() in LifecycleService', explicitly fixed by this PR and now closed.

  • Related To: craft-application#428 (confidence 25%)

    Later lifecycle commit touching the same file shortly after this change; not a fix for this PR.

Related issues

Issue Project State Summary Similarity
#394 Implement `_get_build_for()` in `LifecycleService` craft-application closed Closed as implemented: craft-application PR #414 (commit 947e1b4b, "feat(lifecycle): break out _get_build_for method") extracted LifecycleService._get_build_for() from _init_lifecycle_manager so apps can override it. Shipped in craft-application 4.1.0 (2024-08-14).
85%