← Back to issue list

feat(lifecycle): break out _get_build_for method

View original Github issue

Metadata

Project
craft-application
Number
#414
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged a refactoring that extracts the _get_build_for method from the lifecycle module, resolving issue #394. Approved by two reviewers and passing CI, the change modifies three files with a net addition of 81 lines.

Suggested action:

No scores available.

Issue body

Fixes #394 - [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a refactoring that extracts the _get_build_for method from the lifecycle module, resolving issue #394. Approved by two reviewers and passing CI, the change modifies three files with a net addition of 81 lines.
qwen3.6-35b-a3b-mtp-q6 Merged the lifecycle refactor that extracts the _get_build_for method, resolving issue #394. The change was authored by maintainer lengau and integrated into the main branch without additional review comments.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4540 fix(lifecycle): return correct base when using devel for build-base (… snapcraft merged Merged a fix to return the correct base when using devel for build-base. Approved by two reviewers, the change spans seven files. Codecov noted one uncovered line, but the pull request was successfully merged.
71%