chore: factor run logic outside of try block
Metadata
Current evaluation
Merged PR #466, moving inner run logic outside the generic exception handler so subclasses can override it and translate application-specific exceptions.
Resolution: closed resolved
Reason: PR #466 was approved with no unresolved comments and merged. The refactor separates overridable application run logic from Craft Application's generic exception handling.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This allows applications to override the inner run logic, with the end goal of capturing application specific exceptions and raise appropriate ones for Craft Application to handle.
Without the logic split, overriding run to capture exceptions is virtually impossible as the run method holds a generic Exception handler.
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #466, moving inner run logic outside the generic exception handler so subclasses can override it and translate application-specific exceptions. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #466 moved overridable run logic outside the generic exception handler, allowing subclasses to translate application-specific exceptions. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #466: moved the inner run logic outside the generic try/except, enabling subclasses to handle application-specific exceptions. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Factored run logic outside the try block to allow overriding for application-specific exception handling. Approved by two reviewers and passed CI. |
Update history
No update history recorded yet.
Related issues
No related issues found above the similarity threshold.